tools/perf/page_sets/page_set_unittest.py - Issue 245093003: Move PageSet._InitializeArchive to PageRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/page_set_unittest.py

Issue 245093003: Move PageSet._InitializeArchive to PageRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add # pylint: disable=E202 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/page_set_unittest.py

diff --git a/tools/perf/page_sets/page_set_unittest.py b/tools/perf/page_sets/page_set_unittest.py

index 89dda000ab39408364e7318aff8015684b69037d..db235b3b966a9f328ba575883a923e3d1b13efa8 100644

--- a/tools/perf/page_sets/page_set_unittest.py

+++ b/tools/perf/page_sets/page_set_unittest.py

@@ -19,7 +19,7 @@ class PageSetUnitTest(unittest.TestCase):

page_sets_dir = os.path.dirname(__file__)

page_sets = discover.GetAllPageSetFilenames(page_sets_dir)

for path in page_sets:

- page_set = page_set_module.PageSet.FromFile(path, ignore_archive=True)

+ page_set = page_set_module.PageSet.FromFile(path)

# TODO: Eventually these should be fatal.

if not page_set.archive_data_file:

@@ -31,8 +31,8 @@ class PageSetUnitTest(unittest.TestCase):

continue

wpr_archive_info = page_set_archive_info.PageSetArchiveInfo.FromFile(

- os.path.join(page_sets_dir, page_set.archive_data_file),

- ignore_archive=True)

+ os.path.join(page_sets_dir, page_set.archive_data_file),

+ ignore_archive=True)

logging.info('Testing %s', path)

for page in page_set.pages:

« no previous file with comments | « tools/perf/benchmarks/blink_perf.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »