Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 245093003: Move PageSet._InitializeArchive to PageRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add # pylint: disable=E202 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/page_set_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/blink_perf.py
diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py
index 9dee8658b670f6faf184f06b05cebda47cc60f57..7bba79961345e870bcb352fea6667f666e657f80 100644
--- a/tools/perf/benchmarks/blink_perf.py
+++ b/tools/perf/benchmarks/blink_perf.py
@@ -7,21 +7,9 @@ import os
from telemetry import test
from telemetry.core import util
from telemetry.page import page_measurement
-from telemetry.page import page as page_module
from telemetry.page import page_set
-class BlinkPerfPageSet(page_set.PageSet):
- def __init__(self, file_path, page_urls, serving_dirs):
- super(BlinkPerfPageSet, self).__init__(file_path=file_path,
- serving_dirs=serving_dirs)
-
- for url in page_urls:
- self.AddPage(page_module.PageWithDefaultRunNavigate(
- url, page_set=self, base_dir=self._base_dir))
- self._InitializeArchive()
-
-
def _CreatePageSetFromPath(path):
assert os.path.exists(path)
@@ -60,7 +48,10 @@ def _CreatePageSetFromPath(path):
_AddDir(path, skipped)
else:
_AddPage(path)
- return BlinkPerfPageSet(os.getcwd() + os.sep, page_urls, serving_dirs)
+ ps = page_set.PageSet(file_path=os.getcwd()+os.sep, serving_dirs=serving_dirs)
+ for url in page_urls:
+ ps.AddPageWithDefaultRunNavigate(url)
+ return ps
class _BlinkPerfMeasurement(page_measurement.PageMeasurement):
« no previous file with comments | « no previous file | tools/perf/page_sets/page_set_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698