Move PageSet._InitializeArchive to PageRunner

Move PageSet._InitializeArchive to PageRunner

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265772

[tonyg, 2014-04-22 19:02:41]

Seems a lot cleaner to me, but my eyes crossed a little during the review. I
think Dave or Nat should approve.

[nduca, 2014-04-22 23:32:53]

lgtm sorry for the slow review

https://codereview.chromium.org/245093003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/245093003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/page_runner.py:315: # Attempt to download the
credentials file.
indentation

https://codereview.chromium.org/245093003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/page_set.py (right):

https://codereview.chromium.org/245093003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/page_set.py:92: def AddSimplePageOfUrl(self,
page_url):
AddPageWithDefaultRunNavigate?

[nednguyen, 2014-04-23 03:42:26]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-23 03:43:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/245093003/60001

[commit-bot: I haz the power, 2014-04-23 03:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 03:55:32]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[nednguyen, 2014-04-23 04:29:15]

On 2014/04/23 03:55:32, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.chromium on chromium_presubmit

Hi Nat, the presubmit check complains about wpr_archive_info is set in here
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

How is that a valid complaint since I do define  wpr_archive_info.setter method?
And how do I bypass this without removing
PageMeasurementUnitTest.testRecordAndReplay (this test is actually disabled)?

[dtu, 2014-04-23 17:09:48]

On 2014/04/23 04:29:15, nednguyen wrote:
> On 2014/04/23 03:55:32, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   tryserver.chromium on chromium_presubmit
> 
> Hi Nat, the presubmit check complains about wpr_archive_info is set in here
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> 
> How is that a valid complaint since I do define  wpr_archive_info.setter
method?
> And how do I bypass this without removing
> PageMeasurementUnitTest.testRecordAndReplay (this test is actually disabled)?

Looks like a bug in PyLint:
http://www.logilab.org/ticket/89092

# pylint: disable=E202
if you want to disable it here

Maybe we should disable this check in telemetry's PRESUBMIT.

[dtu, 2014-04-23 17:11:57]

On 2014/04/23 17:09:48, dtu wrote:
> On 2014/04/23 04:29:15, nednguyen wrote:
> > On 2014/04/23 03:55:32, I haz the power (commit-bot) wrote:
> > > Try jobs failed on following builders:
> > >   tryserver.chromium on chromium_presubmit
> > 
> > Hi Nat, the presubmit check complains about wpr_archive_info is set in here
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> > 
> > How is that a valid complaint since I do define  wpr_archive_info.setter
> method?
> > And how do I bypass this without removing
> > PageMeasurementUnitTest.testRecordAndReplay (this test is actually
disabled)?
> 
> Looks like a bug in PyLint:
> http://www.logilab.org/ticket/89092
> 
> # pylint: disable=E202
> if you want to disable it here
> 
> Maybe we should disable this check in telemetry's PRESUBMIT.

Also thanks for this change!

Is there also a cloud_storage call in page_set_archive_info.py that needs to be
moved?

[nednguyen, 2014-04-23 17:22:15]

On 2014/04/23 17:11:57, dtu wrote:
> On 2014/04/23 17:09:48, dtu wrote:
> > On 2014/04/23 04:29:15, nednguyen wrote:
> > > On 2014/04/23 03:55:32, I haz the power (commit-bot) wrote:
> > > > Try jobs failed on following builders:
> > > >   tryserver.chromium on chromium_presubmit
> > > 
> > > Hi Nat, the presubmit check complains about wpr_archive_info is set in
here
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> > > 
> > > How is that a valid complaint since I do define  wpr_archive_info.setter
> > method?
> > > And how do I bypass this without removing
> > > PageMeasurementUnitTest.testRecordAndReplay (this test is actually
> disabled)?
> > 
> > Looks like a bug in PyLint:
> > http://www.logilab.org/ticket/89092
> > 
> > # pylint: disable=E202
> > if you want to disable it here
> > 
> > Maybe we should disable this check in telemetry's PRESUBMIT.
> 
> Also thanks for this change!
> 
> Is there also a cloud_storage call in page_set_archive_info.py that needs to
be
> moved?
The page_set_archive_info.PageSetArchiveInfo.FromFile(..) call in
PageSet.wpr_archive_info will download all .wpr files.

[nednguyen, 2014-04-23 17:22:47]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-23 17:22:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/245093003/70001

[commit-bot: I haz the power, 2014-04-23 21:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 21:33:08]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[nednguyen, 2014-04-23 21:35:21]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-23 21:36:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/245093003/70001

[commit-bot: I haz the power, 2014-04-23 23:34:34]

Change committed as 265772