ui/views/controls/combobox/combobox.cc - Issue 2450903002: MacViews: Clear mouse handler when showing context menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 2450903002: MacViews: Clear mouse handler when showing context menus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_button.cc ('k') | ui/views/controls/menu/menu_controller.cc » ('j') | ui/views/controls/menu/menu_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/combobox/combobox.cc

diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc

index cc474726ba960ea528b48f698a89ba36e401370c..c519cd5d5bd513483edbb053fd84abb169fec8ae 100644

--- a/ui/views/controls/combobox/combobox.cc

+++ b/ui/views/controls/combobox/combobox.cc

@@ -947,11 +947,6 @@ void Combobox::OnMenuClosed(Button::ButtonState original_button_state) {

if (arrow_button_)

arrow_button_->SetState(original_button_state);

closed_time_ = base::Time::Now();

- // Need to explicitly clear mouse handler so that events get sent

- // properly after the menu finishes running. If we don't do this, then

- // the first click to other parts of the UI is eaten.

- SetMouseHandler(NULL);

}

void Combobox::OnPerformAction() {

« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_button.cc ('k') | ui/views/controls/menu/menu_controller.cc » ('j') | ui/views/controls/menu/menu_runner.cc » ('J')