Issue 2450853005: Don't invoke load algorithm when a media element is moved into a new document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2450853005: Don't invoke load algorithm when a media element is moved into a new document.

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews, nessy, feature-media-reviews_chromium.org, posciak+watch_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, mlamouri+watch-blink_chromium.org, dglazkov+blink, blink-reviews, Srirama, vcarbune.chromium

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't invoke load algorithm when a media element is moved into a new document. This was done for historical reasons (avoid crashes) and it does not seem to be needed anymore. BUG=657453

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -29 lines)			Patch
	M	third_party/WebKit/LayoutTests/media/video-move-to-new-document.html	View		1 chunk	+31 lines, -27 lines	0 comments	Download
	M	third_party/WebKit/Source/core/html/HTMLMediaElement.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-10-26 13:57:55 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450853005/1

4 years, 1 month ago (2016-10-26 13:58:17 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-10-26 15:13:18 UTC) #3

commit-bot: I haz the power

4 years, 1 month ago (2016-10-26 15:13:18 UTC) #4

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages