Separate rAF aligned Touch and Mouse Input settings

Separate rAF aligned Touch and Mouse Input settings

We wish to ship rAF aligned touch input without shipping
the mouse part due to historical points. So break them
into two separate settings.

BUG=642368
Committed: https://crrev.com/36b767654b6b6701cd41dc97371b71b35a876ed5
Cr-Commit-Position: refs/heads/master@{#427676}

[dtapuska, 2016-10-25 16:03:59]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 16:04:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-10-25 16:04:59]

dtapuska@chromium.org changed reviewers:
+ creis@chromium.org, rkaplow@chromium.org, tdresser@chromium.org

[commit-bot: I haz the power, 2016-10-25 16:48:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 16:48:20]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-10-25 16:58:46]

LGTM from an owners perspective if tdresser and rkaplow approve.

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
File content/renderer/input/main_thread_event_queue.cc (right):

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
content/renderer/input/main_thread_event_queue.cc:17: bool
isPossiblyContinuousEvent(
Style nit: "Is" should be capitalized.

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
File content/renderer/input/main_thread_event_queue.h (right):

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
content/renderer/input/main_thread_event_queue.h:145: bool
RafAlignedInputDisabled();
nit: IsRafAlignedInputDisabled?

[tdresser, 2016-10-25 17:37:44]

Other than naming, LGTM.

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
File content/renderer/input/main_thread_event_queue.cc (right):

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
content/renderer/input/main_thread_event_queue.cc:295: bool
MainThreadEventQueue::IsContinuousEvent(
Can we name this more clearly? Whether or not rAF aligned input is enabled
doesn't impact whether or not the event type is continuous.

[rkaplow, 2016-10-25 20:05:52]

lgtm

https://codereview.chromium.org/2450833003/diff/1/content/public/common/conte...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2450833003/diff/1/content/public/common/conte...
content/public/common/content_features.cc:144: const base::Feature
kRafAlignedTouchInputEvents{
should be alphabetized

[dtapuska, 2016-10-26 02:34:52]

https://codereview.chromium.org/2450833003/diff/1/content/public/common/conte...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2450833003/diff/1/content/public/common/conte...
content/public/common/content_features.cc:144: const base::Feature
kRafAlignedTouchInputEvents{
On 2016/10/25 20:05:51, rkaplow wrote:
> should be alphabetized

Done.

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
File content/renderer/input/main_thread_event_queue.cc (right):

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
content/renderer/input/main_thread_event_queue.cc:17: bool
isPossiblyContinuousEvent(
On 2016/10/25 16:58:46, Charlie Reis wrote:
> Style nit: "Is" should be capitalized.

Done.

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
content/renderer/input/main_thread_event_queue.cc:295: bool
MainThreadEventQueue::IsContinuousEvent(
On 2016/10/25 17:37:44, tdresser wrote:
> Can we name this more clearly? Whether or not rAF aligned input is enabled
> doesn't impact whether or not the event type is continuous.

Done.

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
File content/renderer/input/main_thread_event_queue.h (right):

https://codereview.chromium.org/2450833003/diff/1/content/renderer/input/main...
content/renderer/input/main_thread_event_queue.h:145: bool
RafAlignedInputDisabled();
On 2016/10/25 16:58:46, Charlie Reis wrote:
> nit: IsRafAlignedInputDisabled?

Done.

[dtapuska, 2016-10-26 02:35:05]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-10-26 02:35:05]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
rkaplow@chromium.org, tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2450833003/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-10-26 02:35:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:00:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:00:13]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dtapuska, 2016-10-26 12:50:25]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-10-26 12:50:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 13:30:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 13:32:34]

Description was changed from

==========
Separate rAF aligned Touch and Mouse Input settings

We wish to ship rAF aligned touch input without shipping
the mouse part due to historical points. So break them
into two separate settings.

BUG=642368
==========

to

==========
Separate rAF aligned Touch and Mouse Input settings

We wish to ship rAF aligned touch input without shipping
the mouse part due to historical points. So break them
into two separate settings.

BUG=642368

Committed: https://crrev.com/36b767654b6b6701cd41dc97371b71b35a876ed5
Cr-Commit-Position: refs/heads/master@{#427676}
==========

[commit-bot: I haz the power, 2016-10-26 13:32:35]

Patchset 2 (id:??) landed as
https://crrev.com/36b767654b6b6701cd41dc97371b71b35a876ed5
Cr-Commit-Position: refs/heads/master@{#427676}