Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2450833002: Verify that an event queue is present before firing an event. (Closed)

Created:
4 years, 1 month ago by Mike West
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify that an event queue is present before firing an event. BUG=658984 R=jochen@chromium.org Committed: https://crrev.com/6524ad09faec33bfe9f6e2ddeaa568c8ae5c9b31 Cr-Commit-Position: refs/heads/master@{#427667}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
Ugh. WDYT?
4 years, 1 month ago (2016-10-25 14:56:57 UTC) #1
jochen (gone - plz use gerrit)
lgtm with comment https://codereview.chromium.org/2450833002/diff/1/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp File third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp (right): https://codereview.chromium.org/2450833002/diff/1/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp#newcode1255 third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp:1255: if (!document->domWindow() || !document->domWindow()->getEventQueue()) please either ...
4 years, 1 month ago (2016-10-26 08:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450833002/20001
4 years, 1 month ago (2016-10-26 09:40:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 11:09:08 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 11:10:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6524ad09faec33bfe9f6e2ddeaa568c8ae5c9b31
Cr-Commit-Position: refs/heads/master@{#427667}

Powered by Google App Engine
This is Rietveld 408576698