Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 24508006: remove uses of static oddball accessors using GetCurrent in advance of removal from api (Closed)

Created:
7 years, 2 months ago by dcarney
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

remove uses of static oddball accessors using GetCurrent in advance of removal from api R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16957

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -110 lines) Patch
M include/v8.h View 2 chunks +3 lines, -2 lines 0 comments Download
M samples/lineprocessor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 12 chunks +31 lines, -14 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-accessors.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 26 chunks +64 lines, -56 lines 0 comments Download
M test/cctest/test-debug.cc View 9 chunks +16 lines, -12 lines 0 comments Download
M test/cctest/test-decls.cc View 15 chunks +19 lines, -17 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
ptal
7 years, 2 months ago (2013-09-26 08:12:40 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/24508006/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/24508006/diff/1/src/api.cc#newcode1013 src/api.cc:1013: if (data.IsEmpty()) nit: Curly braces if it doesn't ...
7 years, 2 months ago (2013-09-26 08:17:22 UTC) #2
dcarney
7 years, 2 months ago (2013-09-26 08:22:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698