Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 24508003: Revert 222826 "Copy the thread name to the stack for debugging p..." (Closed)

Created:
7 years, 2 months ago by Robert Sesek
Modified:
7 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 222826 "Copy the thread name to the stack for debugging p..." > Copy the thread name to the stack for debugging purposes. > > The this ptr in Thread is getting smashed after the MessageLoop ends, which > leaves very little to go on. This is kind of a stab in the dark, but hopefully > it makes something bleed in a general direction. > > BUG=274705 > TEST=Minidumps contain 47 bytes of thread name data way high on the stack. > R=mark@chromium.org > > Review URL: https://codereview.chromium.org/23606030 TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M trunk/src/base/threading/thread.cc View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
7 years, 2 months ago (2013-09-25 19:31:39 UTC) #1
Robert Sesek
7 years, 2 months ago (2013-09-25 19:31:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r225228.

Powered by Google App Engine
This is Rietveld 408576698