[promises] remove PromiseEnqueue

[promises] remove PromiseEnqueue

Removes PromiseEnqueue and moves debugging code to a separate
function which gets called when the debugger is active.

BUG=v8:5343
Committed: https://crrev.com/c6722aeae18751d836849db997c9edf28a4dd7a4
Cr-Commit-Position: refs/heads/master@{#40562}

[gsathya, 2016-10-25 09:03:42]

Description was changed from

==========
fmt


works


wip

BUG=
==========

to

==========
[promises] remove PromiseEnqueue

Removes PromiseEnqueue and moves debugging code to a separate function which
gets called when the debugger is active.

BUG=v8:5343
==========

[gsathya, 2016-10-25 09:05:52]

Description was changed from

==========
[promises] remove PromiseEnqueue

Removes PromiseEnqueue and moves debugging code to a separate function which
gets called when the debugger is active.

BUG=v8:5343
==========

to

==========
[promises] remove PromiseEnqueue

Removes PromiseEnqueue and moves debugging code to a separate 
function which gets called when the debugger is active.

BUG=v8:5343
==========

[gsathya, 2016-10-25 09:06:34]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org

[gsathya, 2016-10-25 09:08:41]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 09:08:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 09:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 09:36:50]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-10-25 11:05:30]

https://codereview.chromium.org/2450763002/diff/1/src/runtime/runtime-interna...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2450763002/diff/1/src/runtime/runtime-interna...
src/runtime/runtime-internal.cc:585: MaybeHandle<Object> maybe_result,
maybe_exception;
Looks like you don't use maybe_exception, so I'd just leave it out.

https://codereview.chromium.org/2450763002/diff/1/src/runtime/runtime-interna...
src/runtime/runtime-internal.cc:592: if ((maybe_result).ToHandle(&result) &&
result->IsJSArray()) {
No need for the parens around maybe_result.

Can we just CHECK(result->IsJSArray()) instead inside the if statement? If the
call succeeds it has to be an array.

[gsathya, 2016-10-25 11:12:31]

https://codereview.chromium.org/2450763002/diff/1/src/runtime/runtime-interna...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2450763002/diff/1/src/runtime/runtime-interna...
src/runtime/runtime-internal.cc:585: MaybeHandle<Object> maybe_result,
maybe_exception;
On 2016/10/25 11:05:30, adamk wrote:
> Looks like you don't use maybe_exception, so I'd just leave it out.

Done.

https://codereview.chromium.org/2450763002/diff/1/src/runtime/runtime-interna...
src/runtime/runtime-internal.cc:592: if ((maybe_result).ToHandle(&result) &&
result->IsJSArray()) {
On 2016/10/25 11:05:30, adamk wrote:
> No need for the parens around maybe_result.
> 
> Can we just CHECK(result->IsJSArray()) instead inside the if statement? If the
> call succeeds it has to be an array.

Done.

[adamk, 2016-10-25 11:15:45]

lgtm % formatting

https://codereview.chromium.org/2450763002/diff/20001/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/2450763002/diff/20001/src/js/promise.js#newco...
src/js/promise.js:392: onResolve, resultCapability, kFulfilled);
Nit: please re-indent here and below.

[gsathya, 2016-10-25 11:17:07]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2016-10-25 11:17:08]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2450763002/#ps40001
(title: "fmt")

[commit-bot: I haz the power, 2016-10-25 11:17:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 12:33:05]

Description was changed from

==========
[promises] remove PromiseEnqueue

Removes PromiseEnqueue and moves debugging code to a separate 
function which gets called when the debugger is active.

BUG=v8:5343
==========

to

==========
[promises] remove PromiseEnqueue

Removes PromiseEnqueue and moves debugging code to a separate 
function which gets called when the debugger is active.

BUG=v8:5343
==========

[commit-bot: I haz the power, 2016-10-25 12:33:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:12:33]

Description was changed from

==========
[promises] remove PromiseEnqueue

Removes PromiseEnqueue and moves debugging code to a separate 
function which gets called when the debugger is active.

BUG=v8:5343
==========

to

==========
[promises] remove PromiseEnqueue

Removes PromiseEnqueue and moves debugging code to a separate
function which gets called when the debugger is active.

BUG=v8:5343

Committed: https://crrev.com/c6722aeae18751d836849db997c9edf28a4dd7a4
Cr-Commit-Position: refs/heads/master@{#40562}
==========

[commit-bot: I haz the power, 2016-11-17 22:12:35]

Patchset 3 (id:??) landed as
https://crrev.com/c6722aeae18751d836849db997c9edf28a4dd7a4
Cr-Commit-Position: refs/heads/master@{#40562}