Fix more namespace conflicts in SkGifImageReader

Fix more namespace conflicts in SkGifImageReader

To fix Google3
TBR=benjaminwagner@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2450753003

NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/f9acbe28953634c25c4171fd6d5a81976f8c8f38

[scroggo_chromium, 2016-10-25 18:08:30]

Description was changed from

==========
Fix more namespace conflicts in SkGifImageReader

To fix Google3
TBR=benjaminwagner@google.com
==========

to

==========
Fix more namespace conflicts in SkGifImageReader

To fix Google3
TBR=benjaminwagner@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2450753003
==========

[scroggo, 2016-10-25 18:09:07]

scroggo@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2016-10-25 18:09:07]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-10-25 18:09:08]

lgtm

[commit-bot: I haz the power, 2016-10-25 18:09:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dogben, 2016-10-25 18:20:13]

https://codereview.chromium.org/2450753003/diff/1/third_party/gif/SkGifImageR...
File third_party/gif/SkGifImageReader.h (right):

https://codereview.chromium.org/2450753003/diff/1/third_party/gif/SkGifImageR...
third_party/gif/SkGifImageReader.h:59: #define MAX_DICTIONARY_ENTRY_BITS 12
Should these should be prefixed also?

https://codereview.chromium.org/2450753003/diff/1/third_party/gif/SkGifImageR...
third_party/gif/SkGifImageReader.h:64: constexpr int cLoopCountNotSeen = -2;
Should be prefixed.

[scroggo, 2016-10-25 18:24:59]

The CQ bit was unchecked by scroggo@google.com

[scroggo, 2016-10-25 18:33:53]

https://codereview.chromium.org/2450753003/diff/1/third_party/gif/SkGifImageR...
File third_party/gif/SkGifImageReader.h (right):

https://codereview.chromium.org/2450753003/diff/1/third_party/gif/SkGifImageR...
third_party/gif/SkGifImageReader.h:59: #define MAX_DICTIONARY_ENTRY_BITS 12
On 2016/10/25 18:20:12, dogben wrote:
> Should these should be prefixed also?

Done.

https://codereview.chromium.org/2450753003/diff/1/third_party/gif/SkGifImageR...
third_party/gif/SkGifImageReader.h:64: constexpr int cLoopCountNotSeen = -2;
On 2016/10/25 18:20:13, dogben wrote:
> Should be prefixed.

I moved these into classes, which should take care of this.

[scroggo, 2016-10-25 18:33:56]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-10-25 18:33:57]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/2450753003/#ps40001
(title: "Fix macros")

[commit-bot: I haz the power, 2016-10-25 18:34:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dogben, 2016-10-25 18:58:33]

lgtm

[scroggo_chromium, 2016-10-25 19:41:11]

Description was changed from

==========
Fix more namespace conflicts in SkGifImageReader

To fix Google3
TBR=benjaminwagner@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2450753003
==========

to

==========
Fix more namespace conflicts in SkGifImageReader

To fix Google3
TBR=benjaminwagner@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2450753003

NOTREECHECKS=true
==========

[scroggo_chromium, 2016-10-25 19:42:25]

The CQ bit was unchecked by scroggo@chromium.org

[scroggo_chromium, 2016-10-25 19:42:25]

The CQ bit was checked by scroggo@chromium.org

[commit-bot: I haz the power, 2016-10-25 19:42:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 19:43:23]

Description was changed from

==========
Fix more namespace conflicts in SkGifImageReader

To fix Google3
TBR=benjaminwagner@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2450753003

NOTREECHECKS=true
==========

to

==========
Fix more namespace conflicts in SkGifImageReader

To fix Google3
TBR=benjaminwagner@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2450753003

NOTREECHECKS=true

Committed:
https://skia.googlesource.com/skia/+/f9acbe28953634c25c4171fd6d5a81976f8c8f38
==========

[commit-bot: I haz the power, 2016-10-25 19:43:24]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f9acbe28953634c25c4171fd6d5a81976f8c8f38