third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.html - Issue 2450733002: Make spellcheck_test easier to use

Side by Side Diff: third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.html

Issue 2450733002: Make spellcheck_test easier to use (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js » ('j') | third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../assert_selection.js"></script>	4 <script src="../assert_selection.js"></script>

5 <script src="spellcheck_test.js"></script>	5 <script src="spellcheck_test.js"></script>

6	6

7 <script>	7 <script>

8 // This file tests the functionality of spellcheck_test.js	8 // This file tests the functionality of spellcheck_test.js

9	9

10 test(	10 spellcheck_test(

11 () => spellingMarker(0, 1, 'description').assertValid(),	11 '<div contenteditable>\|</div>',

12 'spellingMarker returns valid Marker.');	12 'insertText zz.',

13	13 '<div contenteditable>__.</div>',
	yosin_UTC9 2016/10/25 09:41:10 How about having expected selection? spellcheck_t How about having expected selection? spellcheck_test( '<div contenteditable>\|</div>', 'insertText zz.', '<div contenteditable>zz.\|</div>', '<div contenteditable>__.\|</div>'); It seems extending existing Serializer is considerable option. I propose to introduce callback or extends Serializer class to handle markers. This might help where markers are. It seems excluding tags is too sparse. spellcheck_test( '<div contenteditable>\|</div>', 'insertText zz.', '<div contenteditable>zz.</div>', ' __'); Xiaocheng 2016/10/25 13:19:16 I don't think it makes too much sense to verify se Show quoted text On 2016/10/25 at 09:41:10, Yosi_UTC9 wrote: > How about having expected selection? > > spellcheck_test( > '<div contenteditable>\|</div>', > 'insertText zz.', > '<div contenteditable>zz.\|</div>', > '<div contenteditable>__.\|</div>'); I don't think it makes too much sense to verify selection in a spellcheck test. In fact, I would like to even omit all tags and extract just the plain text. I don't have a good idea how to do so, though... Another reason not to do so is that we don't have a good way to serialize selection in INPUT or TEXTAREA. Show quoted text > > It seems extending existing Serializer is considerable option. > I propose to introduce callback or extends Serializer class to handle markers. This is worth doing, but maybe not for now as we need to somehow identify the common code paths of the two serializers. I prefer doing it in the future when we have time, as an independent refactoring task. Show quoted text > > > > This might help where markers are. > > It seems excluding tags is too sparse. > spellcheck_test( > '<div contenteditable>\|</div>', > 'insertText zz.', > '<div contenteditable>zz.</div>', > ' __');
14 test(	14 'Mark misspellings after typing.');

15 () => grammarMarker(0, 1, 'description').assertValid(),

16 'grammarMarker returns valid Marker.');

17	15

18 spellcheck_test(	16 spellcheck_test(

19 '<div contentEditable>\|</div>',	17 '<div contenteditable>\|</div>',

20 'insertText wellcome.',	18 'insertText You has the right.',

21 spellingMarker(0, 8, 'welcome'), // 'wellcome'	19 '<div contenteditable>You ~~~ the right.</div>',

22 'Mark misspellings and give replacement suggestions after typing.');	20 'Mark ungrammatical phrases after typing.');

23	21

24 spellcheck_test(	22 spellcheck_test(

25 '<div contentEditable>\|</div>',	23 '<div contenteditable>\|</div>',

26 'insertText zz zz.',	24 'insertText orange,zz,apple.',

27 [spellingMarker(0, 2), spellingMarker(3, 2)], // Both 'zz's	25 // Grammar marker under the whole sentence, and spelling marker under 'zz'.

28 'Mark multiple misspellings after typing.');	26 '<div contenteditable>~~~~~~~##~~~~~~~</div>',

	27 'Mark overlapping grammer and spelling errors.');

29	28

	29 // TODO(editing-dev): Make initial selection work for TEXTAREA.

30 spellcheck_test(	30 spellcheck_test(

31 '<div contentEditable>\|</div>',	31 '<textarea>\|</textarea>',

32 'insertText You has the right.',	32 document => {

33 grammarMarker(4, 3), // 'has'	33 document.querySelector('textarea').focus();

34 'Mark ungrammatical phrases after typing.');	34 document.execCommand('insertText', false, 'zz.');

	35 },

	36 '<textarea>__.</textarea>',

	37 'Mark misspellings in <textarea>.');

	38

	39 // TODO(editing-dev): Make initial selection work for INPUT.

	40 spellcheck_test(

	41 '<input type="text">\|',

	42 document => {

	43 document.querySelector('input').focus();

	44 document.execCommand('insertText', false, 'asd.');

	45 },

	46 '<input type="text" value="___.">',

	47 'Mark misspellings in <input>.');

35 </script>	48 </script>

OLD	NEW