Make header include guards great again

Make header include guards great again

i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER

This lets us remove a hack from the PRESUBMIT.py script that existed
for reasons that are no longer valid, and sets us up to add some
presubmit checks for the GN build.

R=asiva@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/103881d01c6aa2ab385f66bda0c2f5feb9cbb206

[zra, 2016-10-25 12:14:29]

Description was changed from

==========
Clean up presubmit script.
==========

to

==========
Clean up presubmit script.

Preparing to add checks for GN.

Also, we are not using svn anymore.
==========

[zra, 2016-10-25 12:14:55]

zra@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-10-25 16:42:34]

lgtm

https://codereview.chromium.org/2450713004/diff/1/runtime/PRESUBMIT.py
File runtime/PRESUBMIT.py (left):

https://codereview.chromium.org/2450713004/diff/1/runtime/PRESUBMIT.py#oldcode50
runtime/PRESUBMIT.py:50: cleanup_parent = None
Removing this changes the linter's notion of the project root. E.g.:

/usr/local/google/home/rmacnak/ssd/dart2/sdk/runtime/vm/heap.h:5:  #ifndef
header guard has wrong style, please use: RUNTIME_VM_HEAP_H_ 
[build/header_guard] [5]
/usr/local/google/home/rmacnak/ssd/dart2/sdk/runtime/vm/heap.h:400:  #endif line
should be "#endif  // RUNTIME_VM_HEAP_H_"  [build/header_guard] [5]

The comment from TrySvnPathHack suggests we did this so that, back when there
was a way to checkout just the VM without the SDK, the VM-only checkout and SDK
checkout produced the same linter results. Given there's only one kind of
checkout now, perhaps we should just adopt the longer header guards.

[zra, 2016-10-25 20:42:08]

Description was changed from

==========
Clean up presubmit script.

Preparing to add checks for GN.

Also, we are not using svn anymore.
==========

to

==========
Make header include guards great again

i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER

This lets us remove a hack from the PRESUBMIT.py script that existed
for reasons that are no longer valid, and sets us up to add some
presubmit checks for the GN build.
==========

[zra, 2016-10-25 20:42:46]

zra@google.com changed reviewers:
+ asiva@google.com

[zra, 2016-10-25 20:42:47]

+asiva

[siva, 2016-10-26 07:12:59]

lgtm

[zra, 2016-10-26 07:26:08]

Description was changed from

==========
Make header include guards great again

i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER

This lets us remove a hack from the PRESUBMIT.py script that existed
for reasons that are no longer valid, and sets us up to add some
presubmit checks for the GN build.
==========

to

==========
Make header include guards great again

i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER

This lets us remove a hack from the PRESUBMIT.py script that existed
for reasons that are no longer valid, and sets us up to add some
presubmit checks for the GN build.

R=asiva@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/103881d01c6aa2ab385f66bda0c2f5feb9cbb206
==========

[zra, 2016-10-26 07:26:09]

Committed patchset #2 (id:20001) manually as
103881d01c6aa2ab385f66bda0c2f5feb9cbb206.