arc: Register ARC content file system

arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty yet.
It'll be added later.

BUG=654684
TBR=sky@chromium.org for platform_util_unittest.cc

Committed: https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90
Cr-Commit-Position: refs/heads/master@{#427609}

[hashimoto, 2016-10-25 06:31:16]

Description was changed from

==========
arc: Register ARC content file system

The implementation (in chrome/browser/chromeos/arc/fileapi) is empty yet.
It'll be added later.

BUG=654684
==========

to

==========
arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file
system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty
yet.
It'll be added later.

BUG=654684
==========

[hashimoto, 2016-10-25 06:32:03]

hashimoto@chromium.org changed reviewers:
+ hidehiko@chromium.org, mtomasz@chromium.org

[hashimoto, 2016-10-25 06:32:04]

hidehiko@: Please review chrome/browser/chromeos/arc
mtomasz@: Please review chrome/browser/chromeos/fileapi

[hashimoto, 2016-10-25 06:32:09]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 06:32:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtomasz, 2016-10-25 06:39:29]

fileapi lgtm

[commit-bot: I haz the power, 2016-10-25 07:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 07:38:03]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-10-25 16:55:44]

LGTM with minor comments. Sorry for delay.

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chrome_conte...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chrome_conte...
chrome/browser/chrome_content_browser_client.cc:2758: new
arc::ArcContentFileSystemBackendDelegate, external_mount_points,
I know you follow the existing code, but could you please add ()?

cf) the 2. of
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
File chrome/browser/chromeos/fileapi/file_system_backend.cc (right):

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
chrome/browser/chromeos/fileapi/file_system_backend.cc:404: return
std::unique_ptr<storage::FileStreamWriter>();
(optional) Can this be shared with RestrictedNativeLocal case?

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
File chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc (right):

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc:43: NULL,  //
drive_delegate
(optional) nullptr is preferred nowadays?

[Luis Héctor Chávez, 2016-10-25 17:15:47]

lhchavez@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Luis Héctor Chávez, 2016-10-25 17:15:48]

drive-by

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
File chrome/browser/chromeos/fileapi/file_system_backend.h (right):

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
chrome/browser/chromeos/fileapi/file_system_backend.h:75:
FileSystemBackend(FileSystemBackendDelegate* drive_delegate,
Can you clearly document (in code) what pointers will be owned by making them
std::unique_ptr<>?

[hashimoto, 2016-10-26 05:23:13]

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chrome_conte...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chrome_conte...
chrome/browser/chrome_content_browser_client.cc:2758: new
arc::ArcContentFileSystemBackendDelegate, external_mount_points,
On 2016/10/25 16:55:44, hidehiko wrote:
> I know you follow the existing code, but could you please add ()?
> 
> cf) the 2. of
>
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

Replaced with base::MakeUnique().

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
File chrome/browser/chromeos/fileapi/file_system_backend.cc (right):

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
chrome/browser/chromeos/fileapi/file_system_backend.cc:404: return
std::unique_ptr<storage::FileStreamWriter>();
On 2016/10/25 16:55:44, hidehiko wrote:
> (optional) Can this be shared with RestrictedNativeLocal case?

Done.

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
File chrome/browser/chromeos/fileapi/file_system_backend.h (right):

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
chrome/browser/chromeos/fileapi/file_system_backend.h:75:
FileSystemBackend(FileSystemBackendDelegate* drive_delegate,
On 2016/10/25 17:15:47, Luis Héctor Chávez wrote:
> Can you clearly document (in code) what pointers will be owned by making them
> std::unique_ptr<>?

Done.

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
File chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc (right):

https://codereview.chromium.org/2450713002/diff/1/chrome/browser/chromeos/fil...
chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc:43: NULL,  //
drive_delegate
On 2016/10/25 16:55:44, hidehiko wrote:
> (optional) nullptr is preferred nowadays?

Done.

[hashimoto, 2016-10-26 05:24:35]

Description was changed from

==========
arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file
system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty
yet.
It'll be added later.

BUG=654684
==========

to

==========
arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file
system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty
yet.
It'll be added later.

BUG=654684
TBR=sky@chromium.org for platform_util_unittest.cc
==========

[hashimoto, 2016-10-26 05:24:56]

TBRing sky@chromium.org for the addition of nullptr in
chrome/browser/platform_util_unittest.cc.

[hashimoto, 2016-10-26 05:25:02]

The CQ bit was checked by hashimoto@chromium.org

[hashimoto, 2016-10-26 05:25:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/2450713002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-10-26 05:25:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 06:31:13]

Description was changed from

==========
arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file
system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty
yet.
It'll be added later.

BUG=654684
TBR=sky@chromium.org for platform_util_unittest.cc
==========

to

==========
arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file
system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty
yet.
It'll be added later.

BUG=654684
TBR=sky@chromium.org for platform_util_unittest.cc
==========

[commit-bot: I haz the power, 2016-10-26 06:31:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 06:32:54]

Description was changed from

==========
arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file
system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty
yet.
It'll be added later.

BUG=654684
TBR=sky@chromium.org for platform_util_unittest.cc
==========

to

==========
arc: Register ARC content file system

Add ARC delegate to chromeos::FileSystemBackend.
Add ARC content file system as an external file URL type.
Add ArcContentFileSystemService which is responsible to register the file
system.

File system implementation (in chrome/browser/chromeos/arc/fileapi) is empty
yet.
It'll be added later.

BUG=654684
TBR=sky@chromium.org for platform_util_unittest.cc

Committed: https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90
Cr-Commit-Position: refs/heads/master@{#427609}
==========

[commit-bot: I haz the power, 2016-10-26 06:32:55]

Patchset 2 (id:??) landed as
https://crrev.com/a53e7e8054ac086bec20a1c77b543b204d57ba90
Cr-Commit-Position: refs/heads/master@{#427609}