Clean up retry-delay-time code.

Clean up retry-delay-time code.

This CL cleans up retry-delay-time in ArcAndroidManagementChecker.
- Use constexpr and base::TimeDelta::FromXXX family for constants.
- Use base::TimeDelta for member.

BUG=n/a
TEST=Ran trybots.

Committed: https://crrev.com/fc683b2b935e9f0d4d2c14ac60bd86acdc7a769a
Cr-Commit-Position: refs/heads/master@{#427394}

[hidehiko, 2016-10-25 05:22:35]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 05:22:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 05:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 05:53:53]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-10-25 06:12:10]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-10-25 06:12:11]

Luis, this is the CL to address your comment in
https://codereview.chromium.org/2446563002/.

PTAL?

[Luis Héctor Chávez, 2016-10-25 15:29:39]

lgtm with nits

https://codereview.chromium.org/2450683002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/policy/arc_android_management_checker.cc
(right):

https://codereview.chromium.org/2450683002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_android_management_checker.cc:7: #include
<utility>
hmmm is this for std::min? shouldn't it be algorithm?

https://codereview.chromium.org/2450683002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_android_management_checker.cc:93: VLOG(2)
<< "Schedule next android management  check in " << retry_delay_;
nit: remove extra space in this line (between management and check).

[hidehiko, 2016-10-25 17:02:49]

Thank you for review. Submitting.

https://codereview.chromium.org/2450683002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/policy/arc_android_management_checker.cc
(right):

https://codereview.chromium.org/2450683002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_android_management_checker.cc:7: #include
<utility>
On 2016/10/25 15:29:39, Luis Héctor Chávez wrote:
> hmmm is this for std::min? shouldn't it be algorithm?

Oops, you're right. It's algorithm. Fixed.

https://codereview.chromium.org/2450683002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/policy/arc_android_management_checker.cc:93: VLOG(2)
<< "Schedule next android management  check in " << retry_delay_;
On 2016/10/25 15:29:39, Luis Héctor Chávez wrote:
> nit: remove extra space in this line (between management and check).

Done.

[hidehiko, 2016-10-25 17:02:54]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2016-10-25 17:02:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2450683002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-10-25 17:03:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 17:34:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 17:43:43]

Description was changed from

==========
Clean up retry-delay-time code.

This CL cleans up retry-delay-time in ArcAndroidManagementChecker.
- Use constexpr and base::TimeDelta::FromXXX family for constants.
- Use base::TimeDelta for member.

BUG=n/a
TEST=Ran trybots.
==========

to

==========
Clean up retry-delay-time code.

This CL cleans up retry-delay-time in ArcAndroidManagementChecker.
- Use constexpr and base::TimeDelta::FromXXX family for constants.
- Use base::TimeDelta for member.

BUG=n/a
TEST=Ran trybots.

Committed: https://crrev.com/fc683b2b935e9f0d4d2c14ac60bd86acdc7a769a
Cr-Commit-Position: refs/heads/master@{#427394}
==========

[commit-bot: I haz the power, 2016-10-25 17:43:44]

Patchset 2 (id:??) landed as
https://crrev.com/fc683b2b935e9f0d4d2c14ac60bd86acdc7a769a
Cr-Commit-Position: refs/heads/master@{#427394}