DevTools: do not allow using 'this' before call into super.

third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 15 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.SourceFrame}
  * @param {!WebInspector.UISourceCode} uiSourceCode
  */
 WebInspector.UISourceCodeFrame = function(uiSourceCode)
 {
+    WebInspector.SourceFrame.call(this, uiSourceCode.contentURL(), workingCopy);
     this._uiSourceCode = uiSourceCode;
-    WebInspector.SourceFrame.call(this, uiSourceCode.contentURL(), workingCopy);
+    this.setEditable(this._canEditSource());
 
     if (Runtime.experiments.isEnabled("sourceDiff"))
         this._diff = new WebInspector.SourceCodeDiff(uiSourceCode.requestOriginalContent(), this.textEditor);
 
     /** @type {?WebInspector.AutocompleteConfig} */
     this._autocompleteConfig = {isWordChar: WebInspector.TextUtils.isWordChar};
     WebInspector.moduleSetting("textEditorAutocompletion").addChangeListener(this._updateAutocomplete, this);
     this._updateAutocomplete();
 
     this._rowMessageBuckets = {};
     /** @type {!Set<string>} */
     this._typeDecorationsPending = new Set();
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._onWorkingCopyChanged, this);
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyCommitted, this);
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.MessageAdded, this._onMessageAdded, this);
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.MessageRemoved, this._onMessageRemoved, this);
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.LineDecorationAdded, this._onLineDecorationAdded, this);
     this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.LineDecorationRemoved, this._onLineDecorationRemoved, this);
     WebInspector.persistence.addEventListener(WebInspector.Persistence.Events.BindingCreated, this._onBindingChanged, this);
     WebInspector.persistence.addEventListener(WebInspector.Persistence.Events.BindingRemoved, this._onBindingChanged, this);
 
     this.textEditor.addEventListener(WebInspector.SourcesTextEditor.Events.EditorBlurred,
         () => WebInspector.context.setFlavor(WebInspector.UISourceCodeFrame, null));
     this.textEditor.addEventListener(WebInspector.SourcesTextEditor.Events.EditorFocused,
         () => WebInspector.context.setFlavor(WebInspector.UISourceCodeFrame, this));
 
     this._updateStyle();
 
-    this._errorPopoverHelper = new WebInspector.PopoverHelper(this.element, this._getErrorAnchor.bind(this), this._showErrorPopover.bind(this));
+    this._errorPopoverHelper = new WebInspector.PopoverHelper(this.element);
+    this._errorPopoverHelper.initializeCallbacks(this._getErrorAnchor.bind(this), this._showErrorPopover.bind(this));
+
     this._errorPopoverHelper.setTimeout(100, 100);
 
     /**
      * @return {!Promise<?string>}
      */
     function workingCopy()
     {
         if (uiSourceCode.isDirty())
             return /** @type {!Promise<?string>} */(Promise.resolve(uiSourceCode.workingCopy()));
         return uiSourceCode.requestContent();
@@ skipping 22 matching lines @@
     willHide: function()
     {
         WebInspector.SourceFrame.prototype.willHide.call(this);
         WebInspector.context.setFlavor(WebInspector.UISourceCodeFrame, null);
         this.element.ownerDocument.defaultView.removeEventListener("focus", this._boundWindowFocused, false);
         delete this._boundWindowFocused;
         this._uiSourceCode.removeWorkingCopyGetter();
     },
 
     /**
-     * @override
      * @return {boolean}
      */
-    canEditSource: function()
+    _canEditSource: function()
     {
         if (WebInspector.persistence.binding(this._uiSourceCode))
             return true;
         var projectType = this._uiSourceCode.project().type();
         if (projectType === WebInspector.projectTypes.Service || projectType === WebInspector.projectTypes.Debugger || projectType === WebInspector.projectTypes.Formatter)
             return false;
         if (projectType === WebInspector.projectTypes.Network && this._uiSourceCode.contentType() === WebInspector.resourceTypes.Document)
             return false;
         return true;
     },
@@ skipping 84 matching lines @@
     _onBindingChanged: function(event)
     {
         var binding = /** @type {!WebInspector.PersistenceBinding} */(event.data);
         if (binding.network === this._uiSourceCode || binding.fileSystem === this._uiSourceCode)
             this._updateStyle();
     },
 
     _updateStyle: function()
     {
         this.element.classList.toggle("source-frame-unsaved-committed-changes", WebInspector.persistence.hasUnsavedCommittedChanges(this._uiSourceCode));
-        this._textEditor.setReadOnly(!this.canEditSource());
+        this.setEditable(!this._canEditSource());
     },
 
     onUISourceCodeContentChanged: function()
     {
     },
 
     _updateAutocomplete: function()
     {
         this._textEditor.configureAutocomplete(WebInspector.moduleSetting("textEditorAutocompletion").get() ? this._autocompleteConfig : null);
     },
@@ skipping 442 matching lines @@
 
 /**
  * @param {!WebInspector.UISourceCode.Message} a
  * @param {!WebInspector.UISourceCode.Message} b
  * @return {number}
  */
 WebInspector.UISourceCode.Message.messageLevelComparator = function(a, b)
 {
     return WebInspector.UISourceCode.Message._messageLevelPriority[a.level()] - WebInspector.UISourceCode.Message._messageLevelPriority[b.level()];
 };