Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 * Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.FilteredUISourceCodeListDelegate} 9 * @extends {WebInspector.FilteredUISourceCodeListDelegate}
10 * @param {!WebInspector.SourcesView} sourcesView 10 * @param {!WebInspector.SourcesView} sourcesView
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 }; 81 };
82 82
83 /** 83 /**
84 * @constructor 84 * @constructor
85 * @extends {WebInspector.FilteredUISourceCodeListDelegate} 85 * @extends {WebInspector.FilteredUISourceCodeListDelegate}
86 * @param {!Array.<string>} types 86 * @param {!Array.<string>} types
87 * @param {function(?WebInspector.UISourceCode)} callback 87 * @param {function(?WebInspector.UISourceCode)} callback
88 */ 88 */
89 WebInspector.SelectUISourceCodeForProjectTypesDialog = function(types, callback) 89 WebInspector.SelectUISourceCodeForProjectTypesDialog = function(types, callback)
90 { 90 {
91 WebInspector.FilteredUISourceCodeListDelegate.call(this);
91 this._types = types; 92 this._types = types;
92 WebInspector.FilteredUISourceCodeListDelegate.call(this);
93 this._callback = callback; 93 this._callback = callback;
94 }; 94 };
95 95
96 WebInspector.SelectUISourceCodeForProjectTypesDialog.prototype = { 96 WebInspector.SelectUISourceCodeForProjectTypesDialog.prototype = {
97 /** 97 /**
98 * @override 98 * @override
99 * @param {?WebInspector.UISourceCode} uiSourceCode 99 * @param {?WebInspector.UISourceCode} uiSourceCode
100 * @param {number=} lineNumber 100 * @param {number=} lineNumber
101 * @param {number=} columnNumber 101 * @param {number=} columnNumber
102 */ 102 */
(...skipping 28 matching lines...) Expand all
131 * @param {string} name 131 * @param {string} name
132 * @param {!Array.<string>} types 132 * @param {!Array.<string>} types
133 * @param {function(?WebInspector.UISourceCode)} callback 133 * @param {function(?WebInspector.UISourceCode)} callback
134 */ 134 */
135 WebInspector.SelectUISourceCodeForProjectTypesDialog.show = function(name, types , callback) 135 WebInspector.SelectUISourceCodeForProjectTypesDialog.show = function(name, types , callback)
136 { 136 {
137 var filteredItemSelectionDialog = new WebInspector.FilteredListWidget(new We bInspector.SelectUISourceCodeForProjectTypesDialog(types, callback)); 137 var filteredItemSelectionDialog = new WebInspector.FilteredListWidget(new We bInspector.SelectUISourceCodeForProjectTypesDialog(types, callback));
138 filteredItemSelectionDialog.showAsDialog(); 138 filteredItemSelectionDialog.showAsDialog();
139 filteredItemSelectionDialog.setQuery(name); 139 filteredItemSelectionDialog.setQuery(name);
140 }; 140 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698