Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/source_frame/ResourceSourceFrame.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) IBM Corp. 2009 All rights reserved. 3 * Copyright (C) IBM Corp. 2009 All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 16 matching lines...) Expand all
27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 */ 28 */
29 29
30 /** 30 /**
31 * @extends {WebInspector.SourceFrame} 31 * @extends {WebInspector.SourceFrame}
32 * @constructor 32 * @constructor
33 * @param {!WebInspector.ContentProvider} resource 33 * @param {!WebInspector.ContentProvider} resource
34 */ 34 */
35 WebInspector.ResourceSourceFrame = function(resource) 35 WebInspector.ResourceSourceFrame = function(resource)
36 { 36 {
37 WebInspector.SourceFrame.call(this, resource.contentURL(), resource.requestC ontent.bind(resource));
37 this._resource = resource; 38 this._resource = resource;
38 WebInspector.SourceFrame.call(this, resource.contentURL(), resource.requestC ontent.bind(resource));
39 }; 39 };
40 40
41 /** 41 /**
42 * @param {!WebInspector.ContentProvider} resource 42 * @param {!WebInspector.ContentProvider} resource
43 * @param {string} highlighterType 43 * @param {string} highlighterType
44 * @return {!WebInspector.SearchableView} 44 * @return {!WebInspector.SearchableView}
45 */ 45 */
46 WebInspector.ResourceSourceFrame.createSearchableView = function(resource, highl ighterType) 46 WebInspector.ResourceSourceFrame.createSearchableView = function(resource, highl ighterType)
47 { 47 {
48 var sourceFrame = new WebInspector.ResourceSourceFrame(resource); 48 var sourceFrame = new WebInspector.ResourceSourceFrame(resource);
(...skipping 19 matching lines...) Expand all
68 * @return {!Promise} 68 * @return {!Promise}
69 */ 69 */
70 populateTextAreaContextMenu: function(contextMenu, lineNumber, columnNumber) 70 populateTextAreaContextMenu: function(contextMenu, lineNumber, columnNumber)
71 { 71 {
72 contextMenu.appendApplicableItems(this._resource); 72 contextMenu.appendApplicableItems(this._resource);
73 return Promise.resolve(); 73 return Promise.resolve();
74 }, 74 },
75 75
76 __proto__: WebInspector.SourceFrame.prototype 76 __proto__: WebInspector.SourceFrame.prototype
77 }; 77 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698