Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 13 matching lines...) Expand all
24 */ 24 */
25 25
26 /** 26 /**
27 * @constructor 27 * @constructor
28 * @implements {WebInspector.Searchable} 28 * @implements {WebInspector.Searchable}
29 * @extends {WebInspector.ProfileView} 29 * @extends {WebInspector.ProfileView}
30 * @param {!WebInspector.CPUProfileHeader} profileHeader 30 * @param {!WebInspector.CPUProfileHeader} profileHeader
31 */ 31 */
32 WebInspector.CPUProfileView = function(profileHeader) 32 WebInspector.CPUProfileView = function(profileHeader)
33 { 33 {
34 WebInspector.ProfileView.call(this);
34 this._profileHeader = profileHeader; 35 this._profileHeader = profileHeader;
35 this.profile = new WebInspector.CPUProfileDataModel(profileHeader._profile | | profileHeader.protocolProfile()); 36 this.profile = new WebInspector.CPUProfileDataModel(profileHeader._profile | | profileHeader.protocolProfile());
36 this.adjustedTotal = this.profile.profileHead.total; 37 this.adjustedTotal = this.profile.profileHead.total;
37 this.adjustedTotal -= this.profile.idleNode ? this.profile.idleNode.total : 0; 38 this.adjustedTotal -= this.profile.idleNode ? this.profile.idleNode.total : 0;
38 WebInspector.ProfileView.call(this, new WebInspector.CPUProfileView.NodeForm atter(this)); 39 this.initialize(new WebInspector.CPUProfileView.NodeFormatter(this));
39 }; 40 };
40 41
41 WebInspector.CPUProfileView.prototype = { 42 WebInspector.CPUProfileView.prototype = {
42 /** 43 /**
43 * @override 44 * @override
44 */ 45 */
45 wasShown: function() 46 wasShown: function()
46 { 47 {
47 WebInspector.ProfileView.prototype.wasShown.call(this); 48 WebInspector.ProfileView.prototype.wasShown.call(this);
48 var lineLevelProfile = WebInspector.LineLevelProfile.instance(); 49 var lineLevelProfile = WebInspector.LineLevelProfile.instance();
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.s econdsToString(node.self / 1000, true)); 493 pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.s econdsToString(node.self / 1000, true));
493 pushEntryInfoRow(WebInspector.UIString("Aggregated total time"), Number. secondsToString(node.total / 1000, true)); 494 pushEntryInfoRow(WebInspector.UIString("Aggregated total time"), Number. secondsToString(node.total / 1000, true));
494 if (node.deoptReason) 495 if (node.deoptReason)
495 pushEntryInfoRow(WebInspector.UIString("Not optimized"), node.deoptR eason); 496 pushEntryInfoRow(WebInspector.UIString("Not optimized"), node.deoptR eason);
496 497
497 return WebInspector.ProfileView.buildPopoverTable(entryInfo); 498 return WebInspector.ProfileView.buildPopoverTable(entryInfo);
498 }, 499 },
499 500
500 __proto__: WebInspector.ProfileFlameChartDataProvider.prototype 501 __proto__: WebInspector.ProfileFlameChartDataProvider.prototype
501 }; 502 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698