Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @param {number} rowHeight 8 * @param {number} rowHeight
9 * @param {number} headerHeight 9 * @param {number} headerHeight
10 * @param {!WebInspector.NetworkTransferTimeCalculator} calculator 10 * @param {!WebInspector.NetworkTransferTimeCalculator} calculator
(...skipping 12 matching lines...) Expand all
23 this._leftPadding = 5; 23 this._leftPadding = 5;
24 /** @const */ 24 /** @const */
25 this._rightPadding = 5; 25 this._rightPadding = 5;
26 /** @const */ 26 /** @const */
27 this._fontSize = 10; 27 this._fontSize = 10;
28 28
29 this._rowHeight = rowHeight; 29 this._rowHeight = rowHeight;
30 this._headerHeight = headerHeight; 30 this._headerHeight = headerHeight;
31 this._calculator = calculator; 31 this._calculator = calculator;
32 32
33 this._popoverHelper = new WebInspector.PopoverHelper(this.element, this._get PopoverAnchor.bind(this), this._showPopover.bind(this)); 33 this._popoverHelper = new WebInspector.PopoverHelper(this.element);
34 this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), t his._showPopover.bind(this));
34 this._popoverHelper.setTimeout(300, 300); 35 this._popoverHelper.setTimeout(300, 300);
35 36
36 this._vScrollElement = this.contentElement.createChild("div", "network-timel ine-v-scroll"); 37 this._vScrollElement = this.contentElement.createChild("div", "network-timel ine-v-scroll");
37 this._vScrollElement.addEventListener("scroll", this._onScroll.bind(this), { passive: true }); 38 this._vScrollElement.addEventListener("scroll", this._onScroll.bind(this), { passive: true });
38 this._vScrollElement.addEventListener("mousewheel", this._onMouseWheel.bind( this), { passive: true }); 39 this._vScrollElement.addEventListener("mousewheel", this._onMouseWheel.bind( this), { passive: true });
39 this._vScrollContent = this._vScrollElement.createChild("div", "network-time line-v-scroll-content"); 40 this._vScrollContent = this._vScrollElement.createChild("div", "network-time line-v-scroll-content");
40 41
41 this.element.addEventListener("mousewheel", this._onMouseWheel.bind(this), { passive: true }); 42 this.element.addEventListener("mousewheel", this._onMouseWheel.bind(this), { passive: true });
42 this.element.addEventListener("mousemove", this._onMouseMove.bind(this), tru e); 43 this.element.addEventListener("mousemove", this._onMouseMove.bind(this), tru e);
43 this.element.addEventListener("mouseleave", this.setHoveredRequest.bind(this , null), true); 44 this.element.addEventListener("mouseleave", this.setHoveredRequest.bind(this , null), true);
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
639 color = this._rowNavigationRequestColor; 640 color = this._rowNavigationRequestColor;
640 641
641 context.fillStyle = color; 642 context.fillStyle = color;
642 context.rect(0, y, this._offsetWidth, this._rowHeight); 643 context.rect(0, y, this._offsetWidth, this._rowHeight);
643 context.fill(); 644 context.fill();
644 context.restore(); 645 context.restore();
645 }, 646 },
646 647
647 __proto__: WebInspector.VBox.prototype 648 __proto__: WebInspector.VBox.prototype
648 }; 649 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698