Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 * @constructor 32 * @constructor
33 * @extends {WebInspector.PopoverHelper} 33 * @extends {WebInspector.PopoverHelper}
34 * @param {!Element} panelElement 34 * @param {!Element} panelElement
35 * @param {function(!Element, !Event):(!Element|!AnchorBox|undefined)} getAnchor 35 * @param {function(!Element, !Event):(!Element|!AnchorBox|undefined)} getAnchor
36 * @param {function(!Element, function(!WebInspector.RemoteObject, boolean, !Ele ment=):undefined, string):undefined} queryObject 36 * @param {function(!Element, function(!WebInspector.RemoteObject, boolean, !Ele ment=):undefined, string):undefined} queryObject
37 * @param {function()=} onHide 37 * @param {function()=} onHide
38 * @param {boolean=} disableOnClick 38 * @param {boolean=} disableOnClick
39 */ 39 */
40 WebInspector.ObjectPopoverHelper = function(panelElement, getAnchor, queryObject , onHide, disableOnClick) 40 WebInspector.ObjectPopoverHelper = function(panelElement, getAnchor, queryObject , onHide, disableOnClick)
41 { 41 {
42 WebInspector.PopoverHelper.call(this, panelElement, getAnchor, this._showObj ectPopover.bind(this), this._onHideObjectPopover.bind(this), disableOnClick); 42 WebInspector.PopoverHelper.call(this, panelElement, disableOnClick);
43 this.initializeCallbacks(getAnchor, this._showObjectPopover.bind(this), this ._onHideObjectPopover.bind(this));
43 this._queryObject = queryObject; 44 this._queryObject = queryObject;
44 this._onHideCallback = onHide; 45 this._onHideCallback = onHide;
45 this._popoverObjectGroup = "popover"; 46 this._popoverObjectGroup = "popover";
46 panelElement.addEventListener("scroll", this.hidePopover.bind(this), true); 47 panelElement.addEventListener("scroll", this.hidePopover.bind(this), true);
47 }; 48 };
48 49
49 WebInspector.ObjectPopoverHelper.MaxPopoverTextLength = 10000; 50 WebInspector.ObjectPopoverHelper.MaxPopoverTextLength = 10000;
50 51
51 WebInspector.ObjectPopoverHelper.prototype = { 52 WebInspector.ObjectPopoverHelper.prototype = {
52 /** 53 /**
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 */ 194 */
194 _lazyLinkifier: function() 195 _lazyLinkifier: function()
195 { 196 {
196 if (!this._linkifier) 197 if (!this._linkifier)
197 this._linkifier = new WebInspector.Linkifier(); 198 this._linkifier = new WebInspector.Linkifier();
198 return this._linkifier; 199 return this._linkifier;
199 }, 200 },
200 201
201 __proto__: WebInspector.PopoverHelper.prototype 202 __proto__: WebInspector.PopoverHelper.prototype
202 }; 203 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698