DevTools: do not allow using 'this' before call into super.

third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {WebInspector.Searchable}
  * @extends {WebInspector.SimpleView}
- * @param {!WebInspector.ProfileDataGridNode.Formatter} nodeFormatter
- * @param {!Array<string>=} viewTypes
  */
-WebInspector.ProfileView = function(nodeFormatter, viewTypes)
+WebInspector.ProfileView = function()
 {
     WebInspector.SimpleView.call(this, WebInspector.UIString("Profile"));
 
     this._searchableView = new WebInspector.SearchableView(this);
     this._searchableView.setPlaceholder(WebInspector.UIString("Find by cost (>50ms), name or file"));
     this._searchableView.show(this.element);
 
-    viewTypes = viewTypes || [
-        WebInspector.ProfileView.ViewTypes.Flame,
-        WebInspector.ProfileView.ViewTypes.Heavy,
-        WebInspector.ProfileView.ViewTypes.Tree
-    ];
-    this._viewType = WebInspector.settings.createSetting("profileView", WebInspector.ProfileView.ViewTypes.Heavy);
-    this._nodeFormatter = nodeFormatter;
-
     var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([]);
     columns.push({id: "self", title: this.columnHeader("self"), width: "120px", fixedWidth: true, sortable: true, sort: WebInspector.DataGrid.Order.Descending});
     columns.push({id: "total", title: this.columnHeader("total"), width: "120px", fixedWidth: true, sortable: true});
     columns.push({id: "function", title: WebInspector.UIString("Function"), disclosure: true, sortable: true});
 
     this.dataGrid = new WebInspector.DataGrid(columns);
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._sortProfile, this);
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._nodeSelected.bind(this, true));
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.DeselectedNode, this._nodeSelected.bind(this, false));
 
     this.viewSelectComboBox = new WebInspector.ToolbarComboBox(this._changeView.bind(this));
-    var optionNames = new Map([
-        [WebInspector.ProfileView.ViewTypes.Flame, WebInspector.UIString("Chart")],
-        [WebInspector.ProfileView.ViewTypes.Heavy, WebInspector.UIString("Heavy (Bottom Up)")],
-        [WebInspector.ProfileView.ViewTypes.Tree, WebInspector.UIString("Tree (Top Down)")],
-    ]);
-    var options = new Map(viewTypes.map(type => [type, this.viewSelectComboBox.createOption(optionNames.get(type), "", type)]));
-    var optionName = this._viewType.get() || viewTypes[0];
-    var option = options.get(optionName) || options.get(viewTypes[0]);
-    this.viewSelectComboBox.select(option);
 
     this.focusButton = new WebInspector.ToolbarButton(WebInspector.UIString("Focus selected function"), "visibility-toolbar-item");
     this.focusButton.setEnabled(false);
     this.focusButton.addEventListener("click", this._focusClicked, this);
 
     this.excludeButton = new WebInspector.ToolbarButton(WebInspector.UIString("Exclude selected function"), "delete-toolbar-item");
     this.excludeButton.setEnabled(false);
     this.excludeButton.addEventListener("click", this._excludeClicked, this);
 
     this.resetButton = new WebInspector.ToolbarButton(WebInspector.UIString("Restore all functions"), "refresh-toolbar-item");
     this.resetButton.setEnabled(false);
     this.resetButton.addEventListener("click", this._resetClicked, this);
 
     this._linkifier = new WebInspector.Linkifier(new WebInspector.Linkifier.DefaultFormatter(30));
-
-    this._changeView();
-    if (this._flameChart)
-        this._flameChart.update();
 };
 
 /** @enum {string} */
 WebInspector.ProfileView.ViewTypes = {
     Flame: "Flame",
     Tree: "Tree",
     Heavy: "Heavy"
 };
 
 /**
  * @param {!Array<!{title: string, value: string}>} entryInfo
  * @return {!Element}
  */
 WebInspector.ProfileView.buildPopoverTable = function(entryInfo)
 {
     var table = createElement("table");
     for (var entry of entryInfo) {
         var row = table.createChild("tr");
         row.createChild("td").textContent = entry.title;
         row.createChild("td").textContent = entry.value;
     }
     return table;
 };
 
 WebInspector.ProfileView.prototype = {
+    /**
+     * @param {!WebInspector.ProfileDataGridNode.Formatter} nodeFormatter
+     * @param {!Array<string>=} viewTypes
+     */
+    initialize: function(nodeFormatter, viewTypes)

[dgozman, 2016/10/26 00:31:01]

@protected

+    {
+        this._nodeFormatter = nodeFormatter;
+
+        this._viewType = WebInspector.settings.createSetting("profileView", WebInspector.ProfileView.ViewTypes.Heavy);
+        viewTypes = viewTypes || [
+            WebInspector.ProfileView.ViewTypes.Flame,
+            WebInspector.ProfileView.ViewTypes.Heavy,
+            WebInspector.ProfileView.ViewTypes.Tree
+        ];
+
+        var optionNames = new Map([
+            [WebInspector.ProfileView.ViewTypes.Flame, WebInspector.UIString("Chart")],
+            [WebInspector.ProfileView.ViewTypes.Heavy, WebInspector.UIString("Heavy (Bottom Up)")],
+            [WebInspector.ProfileView.ViewTypes.Tree, WebInspector.UIString("Tree (Top Down)")],
+        ]);
+
+        var options = new Map(viewTypes.map(type => [type, this.viewSelectComboBox.createOption(optionNames.get(type), "", type)]));
+        var optionName = this._viewType.get() || viewTypes[0];
+        var option = options.get(optionName) || options.get(viewTypes[0]);
+        this.viewSelectComboBox.select(option);
+
+        this._changeView();
+        if (this._flameChart)
+            this._flameChart.update();
+    },
+
     focus: function()
     {
         if (this._flameChart)
             this._flameChart.focus();
         else
             WebInspector.Widget.prototype.focus.call(this);
     },
 
     /**
      * @param {string} columnId
@@ skipping 498 matching lines @@
     _notifyTempFileReady: function()
     {
         if (this._onTempFileReady) {
             this._onTempFileReady();
             this._onTempFileReady = null;
         }
     },
 
     __proto__: WebInspector.ProfileHeader.prototype
 };