Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/resources/md_history/app.vulcanized.html

Issue 2450663003: MD History: hide tooltip promo when drawer is swiped open (Closed)
Patch Set: settings title fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/app.vulcanized.html
diff --git a/chrome/browser/resources/md_history/app.vulcanized.html b/chrome/browser/resources/md_history/app.vulcanized.html
index 89e0393594438a7c954df8e0eb1de025a8d85c31..50433a02e4a1c4ca70f5056f04c4e096ec654ed7 100644
--- a/chrome/browser/resources/md_history/app.vulcanized.html
+++ b/chrome/browser/resources/md_history/app.vulcanized.html
@@ -730,7 +730,7 @@ iron-icon {
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file. */
-<if expr="not chromeos">
+<if expr="not chromeos and not is_android">
@font-face {
font-family: 'Roboto';
font-style: normal;
@@ -2718,7 +2718,7 @@ paper-tabs {
</style>
<div id="toolbar-container">
- <cr-toolbar id="main-toolbar" page-name="$i18n{title}" clear-label="$i18n{clearSearch}" search-prompt="$i18n{searchPrompt}" hidden$="[[itemsSelected_]]" spinner-active="[[spinnerActive]]" show-menu="[[hasDrawer]]" show-menu-promo="[[showMenuPromo_]]" menu-label="$i18n{historyMenuButton}" menu-promo="$i18n{menuPromo}" close-menu-promo="$i18n{closeMenuPromo}" on-search-changed="onSearchChanged_" on-cr-menu-promo-shown="onMenuPromoShown_">
+ <cr-toolbar id="main-toolbar" page-name="$i18n{title}" clear-label="$i18n{clearSearch}" search-prompt="$i18n{searchPrompt}" hidden$="[[itemsSelected_]]" spinner-active="[[spinnerActive]]" show-menu="[[hasDrawer]]" show-menu-promo="{{showMenuPromo}}" menu-label="$i18n{historyMenuButton}" menu-promo="$i18n{menuPromo}" close-menu-promo="$i18n{closeMenuPromo}" on-search-changed="onSearchChanged_" on-cr-menu-promo-shown="onMenuPromoShown_">
<div class="more-actions">
<template is="dom-if" if="[[showSyncNotice]]">
<button is="paper-icon-button-light" id="info-button" on-click="onInfoButtonTap_" aria-label="$i18n{hasSyncedResultsDescription}">
@@ -3859,15 +3859,18 @@ button.more-vert-button div {
display: block;
height: 100%;
overflow: hidden;
+ z-index: 0;
}
history-toolbar {
background: var(--md-toolbar-color);
+ z-index: 1;
}
#main-container {
height: calc(100% - var(--toolbar-height));
position: relative;
+ z-index: 2;
}
:host([grouped_]) #main-container {
@@ -3890,6 +3893,10 @@ history-toolbar {
display: none;
}
+#drawer {
+ z-index: 3;
+}
+
#drawer-header {
align-items: center;
border-bottom: 1px solid rgba(0, 0, 0, 0.08);
@@ -3926,7 +3933,7 @@ h1 {
</history-router>
<history-toolbar id="toolbar" spinner-active="[[shouldShowSpinner_(queryState_.querying,
queryState_.incremental,
- queryState_.searchTerm)]]" is-grouped-mode="{{grouped_}}" grouped-range="{{queryState_.range}}" search-term="{{queryState_.searchTerm}}" query-start-time="[[queryResult_.info.queryStartTime]]" query-end-time="[[queryResult_.info.queryEndTime]]" has-drawer="[[hasDrawer_]]" show-sync-notice="[[showSyncNotice_(hasSyncedResults, selectedPage_)]]">
+ queryState_.searchTerm)]]" is-grouped-mode="{{grouped_}}" grouped-range="{{queryState_.range}}" search-term="{{queryState_.searchTerm}}" query-start-time="[[queryResult_.info.queryStartTime]]" query-end-time="[[queryResult_.info.queryEndTime]]" has-drawer="[[hasDrawer_]]" show-sync-notice="[[showSyncNotice_(hasSyncedResults, selectedPage_)]]" show-menu-promo="{{showMenuPromo_}}">
</history-toolbar>
<div id="main-container">
@@ -3944,7 +3951,7 @@ h1 {
</div>
<template is="dom-if" if="[[hasDrawer_]]">
- <app-drawer id="drawer" swipe-open="" align="start" tabindex="0">
+ <app-drawer id="drawer" swipe-open="" align="start" tabindex="0" on-opened-changed="onOpenedChanged_">
<div id="drawer-header">
<h1>$i18n{title}</h1>
</div>

Powered by Google App Engine
This is Rietveld 408576698