Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2450653003: [CUPS] Fix a typo error of the fake printer's protocol. (Closed)

Created:
4 years, 1 month ago by xdai1
Modified:
4 years, 1 month ago
Reviewers:
skau
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Fix a typo error of the fake printer's protocol. The typo caused "Assertion error" when viewing details of a CUPS printer. BUG=657672 Committed: https://crrev.com/5ccb4774cad17a028967e67b49a62a96d1f7af0f Cr-Commit-Position: refs/heads/master@{#427522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chromeos/printing/fake_printer_discoverer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
xdai1
skau@, could you help review this CL please? Thanks!
4 years, 1 month ago (2016-10-25 20:57:15 UTC) #2
skau
On 2016/10/25 20:57:15, xdai1 wrote: > skau@, could you help review this CL please? Thanks! ...
4 years, 1 month ago (2016-10-25 22:21:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450653003/1
4 years, 1 month ago (2016-10-25 22:21:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 23:03:27 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 23:06:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ccb4774cad17a028967e67b49a62a96d1f7af0f
Cr-Commit-Position: refs/heads/master@{#427522}

Powered by Google App Engine
This is Rietveld 408576698