[inspector] enable inspector by default

[inspector] enable inspector by default

To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org

Committed: https://crrev.com/d7a18896bd5c4a5d7ce21758af5e8d32d8617bf8
Cr-Commit-Position: refs/heads/master@{#40546}

[kozy, 2016-10-25 02:43:20]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 02:43:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 03:01:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 03:01:39]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11415)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[kozy, 2016-10-25 04:02:05]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 04:02:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-10-25 04:04:46]

Description was changed from

==========
[inspector] fix test runner crash on windows

VS2013 compiler doesn't support %zu and crash with exit code without any useful
log.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
==========

to

==========
[inspector] fix test runner crash on windows

To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't
support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
==========

[kozy, 2016-10-25 04:04:55]

Description was changed from

==========
[inspector] fix test runner crash on windows

To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't
support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
==========

to

==========
[inspector] enable inspector by default

To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't
support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
==========

[kozy, 2016-10-25 04:09:28]

Please take a look!
Everything should work, all tests should pass.

I think that we can somehow improve try bots debugging story - I spent a lot of
time to figure out why tests were failed on windows bot because incorrect type
specifier produce only suspicious exit code without any other meaningful
information on VS2013 C++ compiler.
I can suggest to include pdb files into list of files that is dowloaded with
swarming client on reproduce - it will help me with getting stack.
Are there any plans to migrate windows bot to VS2015?

[commit-bot: I haz the power, 2016-10-25 04:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 04:26:42]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-25 05:05:30]

On 2016/10/25 04:09:28, kozyatinskiy wrote:
> Please take a look!
> Everything should work, all tests should pass.
> 
> I think that we can somehow improve try bots debugging story - I spent a lot
of
> time to figure out why tests were failed on windows bot because incorrect type
> specifier produce only suspicious exit code without any other meaningful
> information on VS2013 C++ compiler.
> I can suggest to include pdb files into list of files that is dowloaded with
> swarming client on reproduce - it will help me with getting stack.
> Are there any plans to migrate windows bot to VS2015?

lgtm.

[Michael Achenbach, 2016-10-25 07:07:28]

lgtm

[Michael Achenbach, 2016-10-25 07:11:49]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-10-25 07:11:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 07:13:37]

Description was changed from

==========
[inspector] enable inspector by default

To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't
support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
==========

to

==========
[inspector] enable inspector by default

To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't
support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
==========

[commit-bot: I haz the power, 2016-10-25 07:13:40]

Committed patchset #2 (id:20001)

[Michael Achenbach, 2016-10-25 13:03:00]

On 2016/10/25 04:09:28, kozyatinskiy wrote:
> Please take a look!
> Everything should work, all tests should pass.
> 
> I think that we can somehow improve try bots debugging story - I spent a lot
of
> time to figure out why tests were failed on windows bot because incorrect type
> specifier produce only suspicious exit code without any other meaningful
> information on VS2013 C++ compiler.
> I can suggest to include pdb files into list of files that is dowloaded with
> swarming client on reproduce - it will help me with getting stack.
> Are there any plans to migrate windows bot to VS2015?

Filed http://crbug.com/v8/5564

MSVS 2015: http://crbug.com/603131

[kozy, 2016-10-25 15:24:48]

On 2016/10/25 13:03:00, machenbach (slow) wrote:
> Filed http://crbug.com/v8/5564
> 
> MSVS 2015: http://crbug.com/603131

Thank you!

[commit-bot: I haz the power, 2016-11-17 22:11:49]

Description was changed from

==========
[inspector] enable inspector by default

To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't
support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
==========

to

==========
[inspector] enable inspector by default

To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't
support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.

BUG=chromium:635948
R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org

Committed: https://crrev.com/d7a18896bd5c4a5d7ce21758af5e8d32d8617bf8
Cr-Commit-Position: refs/heads/master@{#40546}
==========

[commit-bot: I haz the power, 2016-11-17 22:11:50]

Patchset 2 (id:??) landed as
https://crrev.com/d7a18896bd5c4a5d7ce21758af5e8d32d8617bf8
Cr-Commit-Position: refs/heads/master@{#40546}