Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7505)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

Issue 2450633004: Make ToolbarActionsModel ignore calls to AddComponentAction() before initialization (Closed)
Patch Set: Add a TODO Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
index 43a232f2c6f8f405d0faf2f9bca2258c7c7b6399..d0ea37a5c7368d6a5996274e453dd93c7693cc04 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
@@ -1458,6 +1458,18 @@ TEST_F(ToolbarActionsModelUnitTest,
EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(1u));
}
+TEST_F(ToolbarActionsModelUnitTest, AddComponentActionBeforeInitialization) {
+ InitializeEmptyExtensionService();
+ ToolbarActionsModel* toolbar_model = extensions::extension_action_test_util::
+ CreateToolbarModelForProfileWithoutWaitingForReady(profile());
+ ASSERT_FALSE(toolbar_model->actions_initialized());
+
+ // AddComponentAction() should be a no-op if actions_initialized() is false.
+ toolbar_model->AddComponentAction(component_action_id());
+ EXPECT_EQ(0u, toolbar_model->toolbar_items().size());
+ EXPECT_FALSE(toolbar_model->HasComponentAction(component_action_id()));
+}
+
TEST_F(ToolbarActionsModelUnitTest,
NoMigrationToComponentActionWithoutExtension) {
extensions::FeatureSwitch::ScopedOverride enable_redesign(
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698