chrome/browser/ui/toolbar/toolbar_actions_model.h - Issue 2450633004: Make ToolbarActionsModel ignore calls to AddComponentAction() before initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model.h

Issue 2450633004: Make ToolbarActionsModel ignore calls to AddComponentAction() before initialization (Closed)

Patch Set: Add a TODO Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/toolbar_actions_model.h

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model.h b/chrome/browser/ui/toolbar/toolbar_actions_model.h

index c5fc84c7972fff1109330abdb36d8fc92339ab2b..52785a3be3d235d6a8fca753d1dc6a366669d43a 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_model.h

+++ b/chrome/browser/ui/toolbar/toolbar_actions_model.h

@@ -181,6 +181,7 @@ class ToolbarActionsModel

void SetActionVisibility(const std::string& action_id, bool visible);

// ComponentMigrationHelper::ComponentActionDelegate:

+ // AddComponentAction() is a no-op if |actions_initialized_| is false.

void AddComponentAction(const std::string& action_id) override;

void RemoveComponentAction(const std::string& action_id) override;

bool HasComponentAction(const std::string& action_id) const override;

« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/toolbar_actions_model.cc » ('j') | no next file with comments »