chrome/browser/ui/toolbar/toolbar_actions_model.cc - Issue 2450633004: Make ToolbarActionsModel ignore calls to AddComponentAction() before initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model.cc

Issue 2450633004: Make ToolbarActionsModel ignore calls to AddComponentAction() before initialization (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/toolbar_actions_model.cc

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model.cc b/chrome/browser/ui/toolbar/toolbar_actions_model.cc

index 3d586be3b35bc29fd88fcaef625f1948720e7720..f0e83999f120b7556f37082ae8fc17f4cfe393e1 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_model.cc

+++ b/chrome/browser/ui/toolbar/toolbar_actions_model.cc

@@ -649,6 +649,10 @@ void ToolbarActionsModel::RemoveComponentAction(const std::string& action_id) {

RemovePref(component_item);

}

+bool ToolbarActionsModel::ActionsInitialized() const {

+ return actions_initialized_;

void ToolbarActionsModel::IncognitoPopulate() {

DCHECK(profile_->IsOffTheRecord());

const ToolbarActionsModel* original_model =