Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js

Issue 2450603005: [Devtools] Moved NetworkTimelineColumn to NetworkLogViewColumns P2 (Closed)
Patch Set: [Devtools] Moved NetworkTimelineColumn to NetworkLogViewColumns P2 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
index 2b73da61e1acd881d421e17dfba4a210104f7db4..b897ea4f82ee1ef048a6d521663e61bdf22137ee 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
@@ -6,11 +6,10 @@
* @constructor
* @extends {WebInspector.VBox}
* @param {number} rowHeight
- * @param {number} headerHeight
- * @param {!WebInspector.NetworkTransferTimeCalculator} calculator
+ * @param {!WebInspector.NetworkTimeCalculator} calculator
* @param {!Element} scrollContainer
*/
-WebInspector.NetworkTimelineColumn = function(rowHeight, headerHeight, calculator, scrollContainer)
+WebInspector.NetworkTimelineColumn = function(rowHeight, calculator, scrollContainer)
{
// TODO(allada) Make this a shadowDOM when the NetworkTimelineColumn gets moved into NetworkLogViewColumns.
WebInspector.VBox.call(this, false);
@@ -28,7 +27,7 @@ WebInspector.NetworkTimelineColumn = function(rowHeight, headerHeight, calculato
this._fontSize = 10;
this._rowHeight = rowHeight;
- this._headerHeight = headerHeight;
+ this._headerHeight = 0;
this._calculator = calculator;
this._popoverHelper = new WebInspector.PopoverHelper(this.element);
@@ -42,7 +41,7 @@ WebInspector.NetworkTimelineColumn = function(rowHeight, headerHeight, calculato
this.element.addEventListener("mousewheel", this._onMouseWheel.bind(this), { passive: true });
this.element.addEventListener("mousemove", this._onMouseMove.bind(this), true);
- this.element.addEventListener("mouseleave", this.setHoveredRequest.bind(this, null), true);
+ this.element.addEventListener("mouseleave", this.dispatchEventToListeners.bind(this, WebInspector.NetworkTimelineColumn.Events.RequestHovered, null), true);
this._boundScrollContainer = scrollContainer;
this._boundScrollContainer.addEventListener("mousewheel", event => {
@@ -162,7 +161,7 @@ WebInspector.NetworkTimelineColumn.prototype = {
setHoveredRequest: function(request)
{
this._hoveredRequest = request;
- this.scheduleDraw();
+ this.update();
},
/**
@@ -195,7 +194,7 @@ WebInspector.NetworkTimelineColumn.prototype = {
*/
_onMouseMove: function(event)
{
- var request = this._getRequestFromPoint(event.offsetX, event.offsetY);
+ var request = this._getRequestFromPoint(event.offsetX, event.offsetY + event.target.offsetTop);
this.dispatchEventToListeners(WebInspector.NetworkTimelineColumn.Events.RequestHovered, request);
},
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698