Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2450563002: [Chromecast] Change DecryptContext Decrypt API (Closed)

Created:
4 years, 1 month ago by yucliu1
Modified:
4 years, 1 month ago
Reviewers:
slan, gfhuang, halliwell
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, gfhuang+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org, smcgruer2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Change DecryptContext Decrypt API 1. Change |output| from vector<uint8_t> to uint8_t*. 2. Add param |data_offset|. BUG=internal b/31219712 TEST=build cast_shell Committed: https://crrev.com/4881bbb89e62906c9d2f44bc6ebfdc31cbc4861a Cr-Commit-Position: refs/heads/master@{#427275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M chromecast/media/base/decrypt_context_impl.h View 1 chunk +2 lines, -14 lines 0 comments Download
M chromecast/media/base/decrypt_context_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chromecast/public/media/decrypt_context.h View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yucliu1
4 years, 1 month ago (2016-10-24 23:08:29 UTC) #3
halliwell
On 2016/10/24 23:08:29, yucliu1 wrote: lgtm
4 years, 1 month ago (2016-10-24 23:24:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450563002/1
4 years, 1 month ago (2016-10-25 04:36:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 04:40:04 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 04:42:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4881bbb89e62906c9d2f44bc6ebfdc31cbc4861a
Cr-Commit-Position: refs/heads/master@{#427275}

Powered by Google App Engine
This is Rietveld 408576698