Directory upload: remember the last directory chosen, not its parent

Directory upload: remember the last directory chosen, not its parent

When using a file picker, the parent directory of the chosen file is
remembered so that the next file picker starts in the same place. But
when a directory picker is used the directory itself should be
remembered. Make it so.

BUG=658839
R=nasko@chromium.org

Committed: https://crrev.com/0d496dc3e2fd36916d35da7f0afa60aa9b18ab4a
Cr-Commit-Position: refs/heads/master@{#428521}

[jsbell, 2016-10-24 20:50:06]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 20:51:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:02:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:02:42]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[jsbell, 2016-10-26 00:33:15]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 00:33:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:06:55]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-10-27 22:11:07]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 22:11:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-10-27 22:13:28]

nasko@ - could you take a look?

I'm not thrilled with the test so any better suggestions are welcome.

[nasko, 2016-10-27 22:58:24]

I've only moved code around a bit in this area, so not very familiar :).
However, LGTM.

https://codereview.chromium.org/2450543002/diff/40001/chrome/browser/file_sel...
File chrome/browser/file_select_helper_unittest.cc (right):

https://codereview.chromium.org/2450543002/diff/40001/chrome/browser/file_sel...
chrome/browser/file_select_helper_unittest.cc:135: const base::FilePath
file_path_2 = dir_path_2.AppendASCII("file2.txt");
Shouldn't the two files be in the same directory? Can you select multiple files
from separate directories?

[commit-bot: I haz the power, 2016-10-27 23:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:23:26]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jsbell, 2016-10-28 00:21:02]

jsbell@chromium.org changed reviewers:
+ jam@chromium.org

[jsbell, 2016-10-28 00:21:03]

jam@ - can you OWNERS review?

https://codereview.chromium.org/2450543002/diff/40001/chrome/browser/file_sel...
File chrome/browser/file_select_helper_unittest.cc (right):

https://codereview.chromium.org/2450543002/diff/40001/chrome/browser/file_sel...
chrome/browser/file_select_helper_unittest.cc:135: const base::FilePath
file_path_2 = dir_path_2.AppendASCII("file2.txt");
On 2016/10/27 22:58:24, nasko (slow) wrote:
> Shouldn't the two files be in the same directory? Can you select multiple
files
> from separate directories?

Hrm, good point. Doesn't really matter for the test but matching reality is
probably smart.

(I also don't think we allow selection of multiple folders so the
MultiFilesSelected() would never be called if the mode is UploadFolder, but this
class itself doesn't enforce that.)

[jsbell, 2016-10-28 00:21:03]

jsbell@chromium.org changed reviewers:
+ jam@chromium.org

[jsbell, 2016-10-28 00:21:04]

jam@ - can you OWNERS review?

[jsbell, 2016-10-28 00:21:05]

jam@ - can you OWNERS review?

[jam, 2016-10-28 20:58:52]

lgtm

[jsbell, 2016-10-28 21:38:41]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-10-28 21:38:42]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2450543002/#ps60001
(title: "Tweak test file paths")

[commit-bot: I haz the power, 2016-10-28 21:39:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:24:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-28 22:27:58]

Description was changed from

==========
Directory upload: remember the last directory chosen, not its parent

When using a file picker, the parent directory of the chosen file is
remembered so that the next file picker starts in the same place. But
when a directory picker is used the directory itself should be
remembered. Make it so.

BUG=658839
R=nasko@chromium.org
==========

to

==========
Directory upload: remember the last directory chosen, not its parent

When using a file picker, the parent directory of the chosen file is
remembered so that the next file picker starts in the same place. But
when a directory picker is used the directory itself should be
remembered. Make it so.

BUG=658839
R=nasko@chromium.org

Committed: https://crrev.com/0d496dc3e2fd36916d35da7f0afa60aa9b18ab4a
Cr-Commit-Position: refs/heads/master@{#428521}
==========

[commit-bot: I haz the power, 2016-10-28 22:27:59]

Patchset 4 (id:??) landed as
https://crrev.com/0d496dc3e2fd36916d35da7f0afa60aa9b18ab4a
Cr-Commit-Position: refs/heads/master@{#428521}