Apply document's referrer policy on client-initiated reload

Apply document's referrer policy on client-initiated reload

location.reload() has apparently never applied the document's referrer
policy to the reload request.

Before https://codereview.chromium.org/2393633006, this was never
noticed, because the net stack's information about referrer policies was
too coarse to trigger its sanity check that the referrer matches the
referrer policy. So the request would go through fine, but with the
wrong referrer (e.g. a referrer of http://example.com/foo even if the
document's referrer policy was 'origin').

But https://codereview.chromium.org/2393633006 gave the net stack
finer-grained information about referrer policies, so that the sanity
check does catch reload requests where the referrer does not match the
referrer policy. On a DCHECK build, location.reload() on a page with a
referrer policy of, e.g., 'origin' hits a NOTREACHED(). On a non-DCHECK
build, location.reload() flashes a net error page because the request
gets cancelled.

This CL fixes this by using SecurityPolicy::generateReferrer() to set
the referrer on the reload request.

BUG=658707
Committed: https://crrev.com/1dad47f20ed56478257aad69c35141472cff4c18
Cr-Commit-Position: refs/heads/master@{#427712}

[estark, 2016-10-24 20:18:06]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 20:19:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:03:51]

Dry run: This issue passed the CQ dry run.

[estark, 2016-10-24 22:04:49]

estark@chromium.org changed reviewers:
+ jochen@chromium.org

[estark, 2016-10-24 22:04:49]

jochen, PTAL?

[jochen (gone - plz use gerrit), 2016-10-26 08:23:27]

lgtm

[estark, 2016-10-26 15:13:56]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:14:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:35:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 17:12:36]

Description was changed from

==========
Apply document's referrer policy on client-initiated reload

location.reload() has apparently never applied the document's referrer
policy to the reload request.

Before https://codereview.chromium.org/2393633006, this was never
noticed, because the net stack's information about referrer policies was
too coarse to trigger its sanity check that the referrer matches the
referrer policy. So the request would go through fine, but with the
wrong referrer (e.g. a referrer of http://example.com/foo even if the
document's referrer policy was 'origin').

But https://codereview.chromium.org/2393633006 gave the net stack
finer-grained information about referrer policies, so that the sanity
check does catch reload requests where the referrer does not match the
referrer policy. On a DCHECK build, location.reload() on a page with a
referrer policy of, e.g., 'origin' hits a NOTREACHED(). On a non-DCHECK
build, location.reload() flashes a net error page because the request
gets cancelled.

This CL fixes this by using SecurityPolicy::generateReferrer() to set
the referrer on the reload request.

BUG=658707
==========

to

==========
Apply document's referrer policy on client-initiated reload

location.reload() has apparently never applied the document's referrer
policy to the reload request.

Before https://codereview.chromium.org/2393633006, this was never
noticed, because the net stack's information about referrer policies was
too coarse to trigger its sanity check that the referrer matches the
referrer policy. So the request would go through fine, but with the
wrong referrer (e.g. a referrer of http://example.com/foo even if the
document's referrer policy was 'origin').

But https://codereview.chromium.org/2393633006 gave the net stack
finer-grained information about referrer policies, so that the sanity
check does catch reload requests where the referrer does not match the
referrer policy. On a DCHECK build, location.reload() on a page with a
referrer policy of, e.g., 'origin' hits a NOTREACHED(). On a non-DCHECK
build, location.reload() flashes a net error page because the request
gets cancelled.

This CL fixes this by using SecurityPolicy::generateReferrer() to set
the referrer on the reload request.

BUG=658707

Committed: https://crrev.com/1dad47f20ed56478257aad69c35141472cff4c18
Cr-Commit-Position: refs/heads/master@{#427712}
==========

[commit-bot: I haz the power, 2016-10-26 17:12:37]

Patchset 1 (id:??) landed as
https://crrev.com/1dad47f20ed56478257aad69c35141472cff4c18
Cr-Commit-Position: refs/heads/master@{#427712}