Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 245053004: Removing the function call as the called function definition is empty. (Closed)

Created:
6 years, 8 months ago by suyash
Modified:
6 years, 8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removing the function call as the called function definition is empty. There were *FIXME* in thirdparty/Webkit//Source/core/accessibility/AXObjectCache.cpp rregarding no necessity of the functions startCachingComputedObjectAttributesUntilTreeMutates() and stopCachingComputedObjectAttributes() and concerned WebAXObject interfaces. As a call is also from the chromium repository so uploading a patch for the removal of the call. Will soon upload the patch with Webkit side changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/renderer/accessibility/renderer_accessibility_complete.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
suyash
Kindly review the patch! Thanks
6 years, 8 months ago (2014-04-21 12:45:55 UTC) #1
dmazzoni
lgtm
6 years, 8 months ago (2014-04-21 14:48:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/245053004/1
6 years, 8 months ago (2014-04-21 14:48:13 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 16:28:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-21 16:28:31 UTC) #5
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 8 months ago (2014-04-22 04:58:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/245053004/1
6 years, 8 months ago (2014-04-22 04:59:04 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 06:20:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-22 06:20:14 UTC) #9
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 8 months ago (2014-04-22 07:42:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/245053004/1
6 years, 8 months ago (2014-04-22 07:42:59 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 08:51:25 UTC) #12
Message was sent while issue was closed.
Change committed as 265217

Powered by Google App Engine
This is Rietveld 408576698