Adding observer functionality to UINetworkQualityService

Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924
TBR=dimich

Committed: https://crrev.com/eb5958ae41b8c4b4a415a1efe0f1eb9a30fd0530
Cr-Commit-Position: refs/heads/master@{#428387}

[RyanSturm, 2016-10-24 23:14:32]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 23:15:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-10-24 23:44:46]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 23:45:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 01:20:19]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-10-25 17:18:41]

ryansturm@chromium.org changed reviewers:
+ dougarnett@chromium.org, tbansal@chromium.org

[RyanSturm, 2016-10-25 17:18:41]

tbansal, dougarnett: PTAL, I'll wait to land this until we are sure that Offline
Pages wants to consume this.

Doug, does this work for the design you have planned?

[dougarnett, 2016-10-25 17:29:39]

On 2016/10/25 17:18:41, Ryan Sturm wrote:
> tbansal, dougarnett: PTAL, I'll wait to land this until we are sure that
Offline
> Pages wants to consume this.
> 
> Doug, does this work for the design you have planned?

Yes, lgtm.

[tbansal1, 2016-10-25 17:34:18]

lgtm 

I would say you should land it since you have already coded this up with tests,
and it will be useful in future.

https://codereview.chromium.org/2450433003/diff/20001/chrome/browser/net/nqe/...
File chrome/browser/net/nqe/ui_network_quality_estimator_service.h (right):

https://codereview.chromium.org/2450433003/diff/20001/chrome/browser/net/nqe/...
chrome/browser/net/nqe/ui_network_quality_estimator_service.h:35: //
NetworkQualityProvider implmentation:
"implmentation"
typo

https://codereview.chromium.org/2450433003/diff/20001/chrome/browser/net/nqe/...
chrome/browser/net/nqe/ui_network_quality_estimator_service.h:37: void
AddEffectiveConnectionTypeObserver(
You might want to say that this must be called on UI thread, and the observer is
notified on the same thread.

[RyanSturm, 2016-10-25 17:40:32]

Thanks. I'll try to land it today then.

https://codereview.chromium.org/2450433003/diff/20001/chrome/browser/net/nqe/...
File chrome/browser/net/nqe/ui_network_quality_estimator_service.h (right):

https://codereview.chromium.org/2450433003/diff/20001/chrome/browser/net/nqe/...
chrome/browser/net/nqe/ui_network_quality_estimator_service.h:35: //
NetworkQualityProvider implmentation:
On 2016/10/25 17:34:18, tbansal1 wrote:
> "implmentation"
> typo

Done.

https://codereview.chromium.org/2450433003/diff/20001/chrome/browser/net/nqe/...
chrome/browser/net/nqe/ui_network_quality_estimator_service.h:37: void
AddEffectiveConnectionTypeObserver(
On 2016/10/25 17:34:18, tbansal1 wrote:
> You might want to say that this must be called on UI thread, and the observer
is
> notified on the same thread.

Done.

[RyanSturm, 2016-10-25 17:40:38]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-10-25 17:40:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dougarnett@chromium.org, tbansal@chromium.org
Link to the patchset: https://codereview.chromium.org/2450433003/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-10-25 17:41:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 17:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:50:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[RyanSturm, 2016-10-25 18:14:29]

ryansturm@chromium.org changed reviewers:
+ dimich@chromium.org

[RyanSturm, 2016-10-25 18:14:29]

dimich: PTAL; Non-functional change. NQE interface used in testing Offline Pages
added two methods.

[RyanSturm, 2016-10-28 14:47:43]

Description was changed from

==========
Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924
==========

to

==========
Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924

TBR:dimich
==========

[RyanSturm, 2016-10-28 14:48:33]

TBR:dimich

empty override for NQE interface in unittest. I believe doug will implment the
interface once he consumes it.

[RyanSturm, 2016-10-28 14:48:41]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2016-10-28 14:49:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 14:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 14:57:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[RyanSturm, 2016-10-28 15:04:46]

Description was changed from

==========
Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924

TBR:dimich
==========

to

==========
Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924

TBR=dimich
==========

[RyanSturm, 2016-10-28 15:04:55]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2016-10-28 15:05:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 16:00:46]

Description was changed from

==========
Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924

TBR=dimich
==========

to

==========
Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924

TBR=dimich
==========

[commit-bot: I haz the power, 2016-10-28 16:00:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-28 16:19:37]

Description was changed from

==========
Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924

TBR=dimich
==========

to

==========
Adding observer functionality to UINetworkQualityService

When the EffectiveConnectionType changes, the new ECT should be reported
to any observers that wish to listen to ECT changes.

BUG=658924

TBR=dimich

Committed: https://crrev.com/eb5958ae41b8c4b4a415a1efe0f1eb9a30fd0530
Cr-Commit-Position: refs/heads/master@{#428387}
==========

[commit-bot: I haz the power, 2016-10-28 16:19:38]

Patchset 3 (id:??) landed as
https://crrev.com/eb5958ae41b8c4b4a415a1efe0f1eb9a30fd0530
Cr-Commit-Position: refs/heads/master@{#428387}