Let CastMediaBlocker observe MediaSession instead of WebContents

chromecast/browser/cast_media_blocker.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_BROWSER_CAST_MEDIA_BLOCKER_H_
 #define CHROMECAST_BROWSER_CAST_MEDIA_BLOCKER_H_
 
+#include "base/callback.h"

[derekjchow1, 2016/10/24 18:50:33]

callback & callback_forward seems redundant.

[Zhiqiang Zhang (Slow), 2016/10/28 10:36:52]

They are all removed since we don't use callback anymore.

+#include "base/callback_forward.h"
 #include "base/macros.h"
-#include "base/callback_forward.h"
-#include "content/public/browser/web_contents_observer.h"
-
-namespace content {
-class WebContents;
-}  // namespace content
+#include "content/public/browser/media_session_observer.h"
 
 namespace chromecast {
 namespace shell {
 
 // This class implements a blocking mode for web applications and is used in
 // Chromecast internal code. Media is unblocked by default.
-class CastMediaBlocker : public content::WebContentsObserver {
+class CastMediaBlocker : public content::MediaSessionObserver {

[derekjchow1, 2016/10/24 18:50:33]

We actually inherit from this class internally, and override other
WebContentsObserver methods. For this CL, inherit from both observer interfaces,
and add a TODO (with my name stapled to it) to remove the WebContentsObserver
interface. I'll decouple the interfaces after your change lands.

  public:
-  explicit CastMediaBlocker(content::WebContents* web_contents);
+  explicit CastMediaBlocker(content::MediaSession* media_session);
 
   // Constructor for test. |suspend_cb| and |resume_cb| will be called when
   // Suspend() and Resume() are called.
-  CastMediaBlocker(content::WebContents* web_contents,
+  CastMediaBlocker(content::MediaSession* media_session,
                    const base::Closure& suspend_cb,
                    const base::Closure& resume_cb);
 
   ~CastMediaBlocker() override;
 
   // Sets if the web contents is allowed to play media or not. If media is
   // unblocked, previously suspended elements should begin playing again.
   void BlockMediaLoading(bool blocked);
 
   // content::WebContentsObserver implementation:
@@ skipping 27 matching lines @@
   bool suspended_;
   bool controllable_;
 
   DISALLOW_COPY_AND_ASSIGN(CastMediaBlocker);
 };
 
 }  // namespace shell
 }  // namespace chromecast
 
 #endif  // CHROMECAST_BROWSER_CAST_MEDIA_BLOCKER_H_