[MD settings] cookie and site data from dialog to subpage

chrome/browser/resources/settings/site_settings/cookie_tree_node.js

Index: chrome/browser/resources/settings/site_settings/cookie_tree_node.js
diff --git a/chrome/browser/resources/settings/site_settings/cookie_tree_node.js b/chrome/browser/resources/settings/site_settings/cookie_tree_node.js
index 34c91c8e42736ce50a4c1819015a0c77f06b0a3a..d73fb57605663fa9dd090ae226ce48dee5f0ce61 100644
--- a/chrome/browser/resources/settings/site_settings/cookie_tree_node.js
+++ b/chrome/browser/resources/settings/site_settings/cookie_tree_node.js
@@ -134,7 +134,6 @@ cr.define('settings', function() {
      */
     getCookieList: function() {
       var list = [];
-
       for (var group of this.children_) {
         for (var cookie of group.children_) {
           list.push({title: cookie.data.title,
@@ -142,7 +141,6 @@ cr.define('settings', function() {
                      data: cookie.data});
         }
       }
-
       return list;
     },
 
@@ -157,7 +155,6 @@ cr.define('settings', function() {
         var title = siteEntry.data.title;
         var id = siteEntry.data.id;
         var description = '';
-
         if (siteEntry.children_.length == 0)
           continue;
 
@@ -175,7 +172,6 @@ cr.define('settings', function() {
             if (descriptionNode.children_.length > 0)
               dataType = descriptionNode.children_[0].data.type;
           }
-
           var count =
               (dataType == 'cookie') ? descriptionNode.children_.length : 0;
           if (count > 1) {
@@ -184,7 +180,6 @@ cr.define('settings', function() {
             description += getCookieDataCategoryText(
                 dataType, descriptionNode.data.totalUsage);
           }
-

[Dan Beam, 2016/11/01 06:33:27]

why did you make all these changes? ^

[dschuyler, 2016/11/01 18:55:34]

Personal readability and over application of the c++ style guide. Doesn't need
to be checked in though.
I'd still like to keep this last change as it was the most egregious (with a
blank line between one closing brace and another).

[Dan Beam, 2016/11/01 19:10:15]

yeah, last removal is fine

         }
         list.push({ site: title, id: id, localData: description });
       }
@@ -214,6 +209,27 @@ cr.define('settings', function() {
       }
       return null;
     },
+
+    /**
+     * Fetch a CookieTreeNode by site.
+     * @param {string} site The web site to look up.
+     * @param {boolean} recursive Whether to search the children also.
+     * @return {settings.CookieTreeNode} The node found, if any.

[Dan Beam, 2016/11/01 06:33:27]

?settings.CookieTreeNode

[dschuyler, 2016/11/01 18:55:34]

Done.

+     */
+    fetchNodeBySite: function(site, recursive) {
+      for (var i = 0; i < this.children_.length; ++i) {
+        if (this.children_[i] == null)

[Dan Beam, 2016/11/01 06:33:27]

when does this happen?

[dschuyler, 2016/11/01 18:55:34]

This was based on a similar existing function. This also didn't need to be
recursive, so I've reworked it. 

+          return null;
+        if (this.children_[i].data.title == site)
+          return this.children_[i];
+        if (recursive) {
+          var node = this.children_[i].fetchNodeBySite(site, true);
+          if (node != null)
+            return node;
+        }
+      }
+      return null;
+    },
   };
 
   return {