[MD settings] cookie and site data from dialog to subpage

chrome/browser/resources/settings/site_settings/site_data_details_subpage.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+(function() {
+  'use strict';
+
+/**
+ * 'site-data-details-subpage' Display cookie contents.
+ */
+Polymer({
+  is: 'site-data-details-subpage',
+
+  behaviors: [settings.RouteObserverBehavior, CookieTreeBehavior],
+
+  properties: {
+    /**
+     * The cookie entries for the given site.
+     * @type {!Array<!CookieDataItem>}
+     * @private
+     */
+    entries_: Array,
+
+    /** Set the page title on the settings-subpage parent. */
+    pageTitle: {
+      type: String,
+      notify: true,
+    },
+
+    /**
+     * The site to show details for.
+     * @type {!settings.CookieTreeNode}
+     * @private
+     */
+    site_: Object,
+  },
+
+  attached: function() {
+    this.addEventListener('cookie-tree-changed',
+        this.onCookiesLoaded_.bind(this));
+
+    Polymer.dom(this).parentNode.querySelector(
+        '#siteDataDetailsRemoveAll').addEventListener(

[Dan Beam, 2016/11/01 06:33:27]

what is this doing?  adding an event listener to a sibling?  why?

[dschuyler, 2016/11/01 18:55:34]

The goal was to know when that button is pushed, without adding unrelated code
to the parent, and while getting the button positioned correctly. To position
the button within the title area, a content select is used. In essence, we need
to put the button 'over-there' and get the message that it was clicked
'over-here'. I'm happy to learn a better way to get that done if a better way is
available. 

+        'tap', this.onRemoveAll_.bind(this));
+  },
+
+  /**
+   * settings.RouteObserverBehavior
+   * @param {!settings.Route} route
+   * @protected
+   */
+  currentRouteChanged: function(route) {
+    if (settings.getCurrentRoute() != settings.Route.SITE_SETTINGS_DATA_DETAILS)

[Dan Beam, 2016/11/01 06:33:27]

can we use contains() instead of equality?

[dschuyler, 2016/11/01 18:55:35]

I think that's a possibility, but it would also open the possibility of false
positives. The direct comparison is what is used in other cases I've seen with
getCurrentRoute(). The query string is culled from the route iiuc, so that
wouldn't be a problem for the comparison.

+      return;
+    this.siteTitle_ = settings.getQueryParameters().get('site');
+    if (this.siteTitle_ == undefined)

[Dan Beam, 2016/11/01 06:33:27]

if (!this.siteTitle_)

[dschuyler, 2016/11/01 18:55:34]

Done.

+      return;
+    this.loadCookies().then(this.onCookiesLoaded_.bind(this));
+    this.pageTitle = this.siteTitle_;
+  },
+
+  /**
+   * @return {!Array<CookieDataForDisplay>}

[Dan Beam, 2016/11/01 06:33:27]

nit: !CookieDataForDisplay unless any of the items can be null

[dschuyler, 2016/11/01 18:55:35]

Done.

+   * @private
+   */
+  getCookieNodes_: function(cookie) {
+    var node = this.rootCookieNode.fetchNodeById(cookie.id, true);
+    if (!node)
+      return [];
+    return getCookieData(node.data);
+  },
+
+  /**
+   * settings.RouteObserverBehavior
+   * @private
+   */
+  onCookiesLoaded_: function() {
+    var node = this.rootCookieNode.fetchNodeBySite(this.siteTitle_, false);
+    if (node) {
+      this.site_ = node;
+      this.entries_ = this.site_.getCookieList();
+    } else {
+      this.entries_ = [];
+    }
+  },
+
+  /**
+   * Recursively look up a node path for a leaf node with a given id.
+   * @param {!settings.CookieTreeNode} node The node to start with.
+   * @param {string} currentPath The path constructed so far.
+   * @param {string} targetId The id of the target leaf node to look for.
+   * @return {string} The path of the node returned (or blank if not found).
+   * @private
+   */
+  nodePath_: function(node, currentPath, targetId) {
+    if (node.data.id == targetId)
+      return currentPath;
+
+    for (var i = 0; i < node.children_.length; ++i) {
+      var child = node.children_[i];
+      var path = this.nodePath_(
+          child, currentPath + ',' + child.data.id, targetId);
+      if (path.length > 0)
+        return path;
+    }
+    return '';
+  },
+
+  /**
+   * A handler for when the user opts to remove a single cookie.
+   * @param {!Event} item
+   * @return {string}
+   * @private
+   */
+  getEntryDescription_: function(item) {
+    // Frequently there are multiple cookies per site. To avoid showing a list
+    // of '1 cookie', '1 cookie', ... etc, it is better to show the title of the
+    // cookie to differentiate them.
+    if (item.data.type == 'cookie')
+      return item.title;
+    return getCookieDataCategoryText(item.data.type, item.data.totalUsage);
+  },
+
+  /**
+   * A handler for when the user opts to remove a single cookie.
+   * @param {!Event} event
+   * @private
+   */
+  onRemove_: function(event) {
+    this.browserProxy.removeCookie(this.nodePath_(
+        this.site_, this.site_.data.id, event.currentTarget.dataset.id));
+  },
+
+  /**
+   * A handler for when the user opts to remove all cookies.
+   * @param {!Event} event
+   * @private
+   */
+  onRemoveAll_: function(event) {
+    this.browserProxy.removeCookie(this.site_.data.id);
+  },
+});
+
+})();