[MD settings] cookie and site data from dialog to subpage

chrome/browser/resources/settings/site_settings/cookie_tree_node.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{title: string,
  *            id: string,
  *            data: CookieDetails}}
  */
 var CookieDataItem;
@@ skipping 116 matching lines @@
       var node = id == null ? this : this.fetchNodeById(id, true);
       node.children_.splice(firstChild, count);
     },
 
     /**
      * Returns an array of cookies from the current node within the cookie tree.
      * @return {!Array<!CookieDataItem>} The Cookie List.
      */
     getCookieList: function() {
       var list = [];
-
       for (var group of this.children_) {
         for (var cookie of group.children_) {
           list.push({title: cookie.data.title,
                      id: cookie.data.id,
                      data: cookie.data});
         }
       }
-
       return list;
     },
 
     /**
      * Get a summary list of all sites and their stored data.
      * @return {!Array<!CookieDataSummaryItem>} The summary list.
      */
     getSummaryList: function() {
       var list = [];
       for (var i = 0; i < this.children_.length; ++i) {
         var siteEntry = this.children_[i];
         var title = siteEntry.data.title;
         var id = siteEntry.data.id;
         var description = '';
-
         if (siteEntry.children_.length == 0)
           continue;
 
         for (var j = 0; j < siteEntry.children_.length; ++j) {
           var descriptionNode = siteEntry.children_[j];
           if (j > 0)
             description += ', ';
 
           // Some types, like quota, have no description nodes.
           var dataType = '';
           if (descriptionNode.data.type != undefined) {
             dataType = descriptionNode.data.type;
           } else {
             // A description node might not have children when it's deleted.
             if (descriptionNode.children_.length > 0)
               dataType = descriptionNode.children_[0].data.type;
           }
-
           var count =
               (dataType == 'cookie') ? descriptionNode.children_.length : 0;
           if (count > 1) {
             description += loadTimeData.getStringF('cookiePlural', count);
           } else {
             description += getCookieDataCategoryText(
                 dataType, descriptionNode.data.totalUsage);
           }
-

[Dan Beam, 2016/11/01 06:33:27]

why did you make all these changes? ^

[dschuyler, 2016/11/01 18:55:34]

Personal readability and over application of the c++ style guide. Doesn't need
to be checked in though.
I'd still like to keep this last change as it was the most egregious (with a
blank line between one closing brace and another).

[Dan Beam, 2016/11/01 19:10:15]

yeah, last removal is fine

         }
         list.push({ site: title, id: id, localData: description });
       }
       list.sort(function(a, b) {
         return a.site.localeCompare(b.site);
       });
       return list;
     },
 
     /**
      * Fetch a CookieTreeNode by ID.
      * @param {string} id The ID to look up.
      * @param {boolean} recursive Whether to search the children also.
      * @return {settings.CookieTreeNode} The node found, if any.
      */
     fetchNodeById: function(id, recursive) {
       for (var i = 0; i < this.children_.length; ++i) {
         if (this.children_[i] == null)
           return null;
         if (this.children_[i].data.id == id)
           return this.children_[i];
         if (recursive) {
           var node = this.children_[i].fetchNodeById(id, true);
           if (node != null)
             return node;
         }
       }
       return null;
     },
+
+    /**
+     * Fetch a CookieTreeNode by site.
+     * @param {string} site The web site to look up.
+     * @param {boolean} recursive Whether to search the children also.
+     * @return {settings.CookieTreeNode} The node found, if any.

[Dan Beam, 2016/11/01 06:33:27]

?settings.CookieTreeNode

[dschuyler, 2016/11/01 18:55:34]

Done.

+     */
+    fetchNodeBySite: function(site, recursive) {
+      for (var i = 0; i < this.children_.length; ++i) {
+        if (this.children_[i] == null)

[Dan Beam, 2016/11/01 06:33:27]

when does this happen?

[dschuyler, 2016/11/01 18:55:34]

This was based on a similar existing function. This also didn't need to be
recursive, so I've reworked it. 

+          return null;
+        if (this.children_[i].data.title == site)
+          return this.children_[i];
+        if (recursive) {
+          var node = this.children_[i].fetchNodeBySite(site, true);
+          if (node != null)
+            return node;
+        }
+      }
+      return null;
+    },
   };
 
   return {
     CookieTreeNode: CookieTreeNode,
   };
 });