Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Side by Side Diff: chrome/browser/resources/settings/route.js

Issue 2450423002: [MD settings] cookie and site data from dialog to subpage (Closed)
Patch Set: merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('settings', function() { 5 cr.define('settings', function() {
6 /** 6 /**
7 * Class for navigable routes. May only be instantiated within this file. 7 * Class for navigable routes. May only be instantiated within this file.
8 * @constructor 8 * @constructor
9 * @param {string} path 9 * @param {string} path
10 * @private 10 * @private
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 144
145 r.SITE_SETTINGS_HANDLERS = r.SITE_SETTINGS.createChild('/handlers'); 145 r.SITE_SETTINGS_HANDLERS = r.SITE_SETTINGS.createChild('/handlers');
146 146
147 // TODO(tommycli): Find a way to refactor these repetitive category routes. 147 // TODO(tommycli): Find a way to refactor these repetitive category routes.
148 r.SITE_SETTINGS_AUTOMATIC_DOWNLOADS = 148 r.SITE_SETTINGS_AUTOMATIC_DOWNLOADS =
149 r.SITE_SETTINGS.createChild('automaticDownloads'); 149 r.SITE_SETTINGS.createChild('automaticDownloads');
150 r.SITE_SETTINGS_BACKGROUND_SYNC = 150 r.SITE_SETTINGS_BACKGROUND_SYNC =
151 r.SITE_SETTINGS.createChild('backgroundSync'); 151 r.SITE_SETTINGS.createChild('backgroundSync');
152 r.SITE_SETTINGS_CAMERA = r.SITE_SETTINGS.createChild('camera'); 152 r.SITE_SETTINGS_CAMERA = r.SITE_SETTINGS.createChild('camera');
153 r.SITE_SETTINGS_COOKIES = r.SITE_SETTINGS.createChild('cookies'); 153 r.SITE_SETTINGS_COOKIES = r.SITE_SETTINGS.createChild('cookies');
154 r.SITE_SETTINGS_DATA_DETAILS =
155 r.SITE_SETTINGS_COOKIES.createChild('/siteSettings/siteDataDetails');
Dan Beam 2016/11/01 06:33:27 this is kind of an odd URL to me... a saner URL wo
dschuyler 2016/11/01 18:55:34 Done.
154 r.SITE_SETTINGS_IMAGES = r.SITE_SETTINGS.createChild('images'); 156 r.SITE_SETTINGS_IMAGES = r.SITE_SETTINGS.createChild('images');
155 r.SITE_SETTINGS_JAVASCRIPT = r.SITE_SETTINGS.createChild('javascript'); 157 r.SITE_SETTINGS_JAVASCRIPT = r.SITE_SETTINGS.createChild('javascript');
156 r.SITE_SETTINGS_KEYGEN = r.SITE_SETTINGS.createChild('keygen'); 158 r.SITE_SETTINGS_KEYGEN = r.SITE_SETTINGS.createChild('keygen');
157 r.SITE_SETTINGS_LOCATION = r.SITE_SETTINGS.createChild('location'); 159 r.SITE_SETTINGS_LOCATION = r.SITE_SETTINGS.createChild('location');
158 r.SITE_SETTINGS_MICROPHONE = r.SITE_SETTINGS.createChild('microphone'); 160 r.SITE_SETTINGS_MICROPHONE = r.SITE_SETTINGS.createChild('microphone');
159 r.SITE_SETTINGS_NOTIFICATIONS = r.SITE_SETTINGS.createChild('notifications'); 161 r.SITE_SETTINGS_NOTIFICATIONS = r.SITE_SETTINGS.createChild('notifications');
160 r.SITE_SETTINGS_FLASH = r.SITE_SETTINGS.createChild('flash'); 162 r.SITE_SETTINGS_FLASH = r.SITE_SETTINGS.createChild('flash');
161 r.SITE_SETTINGS_POPUPS = r.SITE_SETTINGS.createChild('popups'); 163 r.SITE_SETTINGS_POPUPS = r.SITE_SETTINGS.createChild('popups');
162 r.SITE_SETTINGS_UNSANDBOXED_PLUGINS = 164 r.SITE_SETTINGS_UNSANDBOXED_PLUGINS =
163 r.SITE_SETTINGS.createChild('unsandboxedPlugins'); 165 r.SITE_SETTINGS.createChild('unsandboxedPlugins');
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 RouteObserverBehavior: RouteObserverBehavior, 362 RouteObserverBehavior: RouteObserverBehavior,
361 getRouteForPath: getRouteForPath, 363 getRouteForPath: getRouteForPath,
362 initializeRouteFromUrl: initializeRouteFromUrl, 364 initializeRouteFromUrl: initializeRouteFromUrl,
363 getCurrentRoute: getCurrentRoute, 365 getCurrentRoute: getCurrentRoute,
364 getQueryParameters: getQueryParameters, 366 getQueryParameters: getQueryParameters,
365 lastRouteChangeWasPopstate: lastRouteChangeWasPopstate, 367 lastRouteChangeWasPopstate: lastRouteChangeWasPopstate,
366 navigateTo: navigateTo, 368 navigateTo: navigateTo,
367 navigateToPreviousRoute: navigateToPreviousRoute, 369 navigateToPreviousRoute: navigateToPreviousRoute,
368 }; 370 };
369 }); 371 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698