Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2450413002: Small: Implement CheckResourceUrl (Closed)

Created:
4 years, 1 month ago by vakh (use Gerrit instead)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, vakh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small: Implement CheckResourceUrl Very similar to: https://codereview.chromium.org/2450633003/ BUG=543161 Committed: https://crrev.com/4817cb8914c9130781c5b2bc44cb96f4284b9022 Cr-Commit-Position: refs/heads/master@{#428180}

Patch Set 1 #

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M components/safe_browsing_db/v4_local_database_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (11 generated)
vakh (use Gerrit instead)
TODO: Add the entry in histograms.xml
4 years, 1 month ago (2016-10-27 01:10:49 UTC) #4
vakh (use Gerrit instead)
git rebase
4 years, 1 month ago (2016-10-27 17:26:18 UTC) #7
Nathan Parker
We should have some test for these interface methods. Is there existing Pver3 tests of ...
4 years, 1 month ago (2016-10-27 18:53:40 UTC) #12
Scott Hess - ex-Googler
lgtm
4 years, 1 month ago (2016-10-27 19:20:37 UTC) #13
vakh (use Gerrit instead)
On 2016/10/27 at 18:53:40, nparker wrote: > We should have some test for these interface ...
4 years, 1 month ago (2016-10-27 22:26:20 UTC) #14
Nathan Parker
lgtm (talked in person). Yup, adding tests a bit later (~week) is more efficient.
4 years, 1 month ago (2016-10-27 22:27:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450413002/20001
4 years, 1 month ago (2016-10-27 22:47:26 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 22:55:09 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 22:58:20 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4817cb8914c9130781c5b2bc44cb96f4284b9022
Cr-Commit-Position: refs/heads/master@{#428180}

Powered by Google App Engine
This is Rietveld 408576698