Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2450373002: Fix some remaining issues with Special Locale (Closed)

Created:
4 years, 1 month ago by Ian Wen
Modified:
4 years, 1 month ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some remaining issues with Special Locale This CL fixes issues regarding to recent_tabs' visibility in menu, special engine's existence in special locale, and some dialog bugs. BUG=656512, 658942, 655776 Committed: https://crrev.com/5a610002bc9430a03634337df721352be5985e18 Cr-Commit-Position: refs/heads/master@{#428448}

Patch Set 1 #

Total comments: 1

Patch Set 2 : maria's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/SearchEnginePromoDialog.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ian Wen
Hi Maria, PTAL :) Thanks!
4 years, 1 month ago (2016-10-27 00:26:15 UTC) #2
Maria
lgtm https://codereview.chromium.org/2450373002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java (right): https://codereview.chromium.org/2450373002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java#newcode139 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java:139: // Hide "Recent tabs" in incognito mode or ...
4 years, 1 month ago (2016-10-28 00:50:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450373002/20001
4 years, 1 month ago (2016-10-28 18:19:25 UTC) #6
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-10-28 19:03:50 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 19:09:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a610002bc9430a03634337df721352be5985e18
Cr-Commit-Position: refs/heads/master@{#428448}

Powered by Google App Engine
This is Rietveld 408576698