Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2450363005: Adding/renaming a folder in the bookmark manager should not hide the icon. (Closed)

Created:
4 years, 1 month ago by Peter Kasting
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Adding/renaming a folder in the bookmark manager should not hide the icon. BUG=649629 TEST=Select a folder in the bookmark manager and hit F2. The folder icon should not disappear and the input field for changing the name should have a fully visible border. Type a name and hit enter; the text should not move between before and after you hit enter. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2444373003 Cr-Commit-Position: refs/heads/master@{#428189} (cherry picked from commit 93a5e7c45a78646f04f1de812da3cb41d6667845) Committed: https://chromium.googlesource.com/chromium/src/+/d6b2e22099b28b7345afa03db4dddecadc729c37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/resources/bookmark_manager/css/bmm.css View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peter Kasting
4 years, 1 month ago (2016-10-28 22:47:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6b2e22099b28b7345afa03db4dddecadc729c37.

Powered by Google App Engine
This is Rietveld 408576698