Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2450363002: A different approach to fixing FirstWebContentsProfiler with PlzNavigate. (Closed)

Created:
4 years, 1 month ago by jam
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

A different approach to fixing FirstWebContentsProfiler with PlzNavigate. The previous fix depended on ensuring we add hooks to all the code paths that cause the first active WebContents to get added to the tab strip. We're still missing some code paths. So instead restore the old behavior. Even though it did miss navigation starts, fix that by using the time from NavigationHandle for PlzNavigate. This should restore the metrics for non-PlzNavigate case. For PlzNavigate, the start timings were already different regardless from non-PlzNavigate because of how navigations are structured very differently. This change shouldn't affects things too much for PlzNavigate though, because the only difference should be the IPC time from the renderer to the browser thread. BUG=650349 Review-Url: https://codereview.chromium.org/2448553002 Cr-Commit-Position: refs/heads/master@{#427144} (cherry picked from commit f4ba53f555685c67fc3fb4ffdb18c4ff7baea19c)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/metrics/first_web_contents_profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/first_web_contents_profiler.cc View 3 chunks +29 lines, -9 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jam
4 years, 1 month ago (2016-10-26 23:13:14 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
9b8c9827bad151ac34cbb5900a554d96186e334b.

Powered by Google App Engine
This is Rietveld 408576698