Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3210)

Unified Diff: chrome/renderer/renderer_webkitclient_impl.cc

Issue 245036: Make sudden termination into a counter.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/renderer_webkitclient_impl.cc
===================================================================
--- chrome/renderer/renderer_webkitclient_impl.cc (revision 27696)
+++ chrome/renderer/renderer_webkitclient_impl.cc (working copy)
@@ -132,6 +132,19 @@
}
void RendererWebKitClientImpl::suddenTerminationChanged(bool enabled) {
+ if (enabled) {
+ // We should not get more enables than disables, but we want it to be a
+ // non-fatal error if it does happen.
+ DCHECK_GT(sudden_termination_disables_, 0);
+ sudden_termination_disables_ = std::max(--sudden_termination_disables_, 0);
+ if (sudden_termination_disables_ != 0)
+ return;
+ } else {
+ sudden_termination_disables_++;
+ if (sudden_termination_disables_ != 1)
+ return;
+ }
+
RenderThread* thread = RenderThread::current();
if (thread) // NULL in unittests.
thread->Send(new ViewHostMsg_SuddenTerminationChanged(enabled));
« no previous file with comments | « chrome/renderer/renderer_webkitclient_impl.h ('k') | chrome/test/data/fast_shutdown/on_before_unloader.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698