Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4239)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java

Issue 2450353005: Revert of Showing previews UI for Offline Previews (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
index 637f270589ef2b929181a54ccbb36a7a8d31908e..0b762becd54587c5c5f10ad7592218c42161ec2a 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
@@ -16,21 +16,19 @@
import android.content.Context;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-
-import org.mockito.Mock;
-import org.mockito.MockitoAnnotations;
-import org.robolectric.annotation.Config;
-import org.robolectric.shadows.multidex.ShadowMultiDex;
-
import org.chromium.base.BaseChromiumApplication;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.browser.snackbar.SnackbarManager;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.testing.local.LocalRobolectricTestRunner;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.robolectric.annotation.Config;
+import org.robolectric.shadows.multidex.ShadowMultiDex;
/**
* Unit tests for OfflinePageUtils.
@@ -57,7 +55,6 @@
// TODO(fgorski): This call has to be mocked out until we update OfflinePageUtils.
// It also goes to NetworkChangeNotifier from there.
doReturn(false).when(observer).isConnected();
- doReturn(false).when(observer).isShowingOfflinePreview(any(Tab.class));
// TODO(fgorski): This call has to be mocked out until we update OfflinePageUtils.
doNothing().when(observer).showReloadSnackbar(any(Tab.class));
return observer;
@@ -249,28 +246,6 @@
@Test
@Feature({"OfflinePages"})
- public void testDontShowPreviewSnackbar_onShown() {
- OfflinePageTabObserver observer = createObserver();
-
- connect(observer, false);
- hideTab(null);
-
- observer.startObservingTab(mTab);
- doReturn(true).when(observer).isShowingOfflinePreview(mTab);
- observer.onPageLoadFinished(mTab);
-
- verify(observer, times(0)).showReloadSnackbar(any(Tab.class));
- assertFalse(observer.wasSnackbarSeen(mTab));
- showTab(observer);
-
- verify(observer, times(0)).showReloadSnackbar(any(Tab.class));
- assertTrue(observer.isObservingTab(mTab));
- assertTrue(observer.isLoadedTab(mTab));
- assertFalse(observer.wasSnackbarSeen(mTab));
- }
-
- @Test
- @Feature({"OfflinePages"})
public void testOnShown_notConnected() {
OfflinePageTabObserver observer = createObserver();

Powered by Google App Engine
This is Rietveld 408576698