chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java - Issue 2450353005: Revert of Showing previews UI for Offline Previews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

Issue 2450353005: Revert of Showing previews UI for Offline Previews (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

index e1027e91bc3fd9a2f88705be679365bcd72c72a4..28749599ffd23977b2eb4bb1add408893fcc9f34 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java

@@ -218,15 +218,9 @@

return OfflinePageUtils.isConnected();

}

- @VisibleForTesting

- boolean isShowingOfflinePreview(Tab tab) {

- return OfflinePageUtils.isShowingOfflinePreview(tab);

- }

void maybeShowReloadSnackbar(Tab tab, boolean isNetworkEvent) {

- // Exclude Offline Previews, as there is a seperate UI for previews.

if (tab == null || tab.isFrozen() || tab.isHidden() || !tab.isOfflinePage()

- || isShowingOfflinePreview(tab) || !isConnected() || !isLoadedTab(tab)

+ || !isConnected() || !isLoadedTab(tab)

|| (wasSnackbarSeen(tab) && !isNetworkEvent)) {

// Conditions to show a snackbar are not met.

return;