chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc - Issue 2450353005: Revert of Showing previews UI for Offline Previews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc

Issue 2450353005: Revert of Showing previews UI for Offline Previews (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/previews/previews_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc

index a9e0815c083ae27784bd7b9fe4baace2185c6dbf..56981a3f71bc362fdae31de14f501d6887620499 100644

--- a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc

@@ -112,7 +112,7 @@

#if BUILDFLAG(ANDROID_JAVA_UI)

offline_pages::OfflinePageTabHelper* tab_helper =

offline_pages::OfflinePageTabHelper::FromWebContents(web_contents);

- return tab_helper && tab_helper->IsShowingOfflinePreview();

+ return tab_helper && tab_helper->is_offline_preview();

#else

return false;

#endif // BUILDFLAG(ANDROID_JAVA_UI)

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/previews/previews_infobar_delegate.cc » ('j') | no next file with comments »