Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.cc

Issue 2450353005: Revert of Showing previews UI for Offline Previews (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
index 6e41b3284ba1c7ce3fae469cab4b6c5a13cb703e..9858838ba12151d848a41b65c9d6419076dd28ea 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
@@ -29,7 +29,7 @@
void OfflinePageTabHelper::LoadedOfflinePageInfo::Clear() {
offline_page.reset();
offline_header.Clear();
- is_showing_offline_preview = false;
+ is_offline_preview = false;
}
OfflinePageTabHelper::OfflinePageTabHelper(content::WebContents* web_contents)
@@ -87,8 +87,8 @@
offline_info_.offline_page =
std::move(provisional_offline_info_.offline_page);
offline_info_.offline_header = provisional_offline_info_.offline_header;
- offline_info_.is_showing_offline_preview =
- provisional_offline_info_.is_showing_offline_preview;
+ offline_info_.is_offline_preview =
+ provisional_offline_info_.is_offline_preview;
}
provisional_offline_info_.Clear();
@@ -170,18 +170,11 @@
provisional_offline_info_.offline_page =
base::MakeUnique<OfflinePageItem>(offline_page);
provisional_offline_info_.offline_header = offline_header;
- provisional_offline_info_.is_showing_offline_preview = is_offline_preview;
+ provisional_offline_info_.is_offline_preview = is_offline_preview;
}
const OfflinePageItem* OfflinePageTabHelper::GetOfflinePageForTest() const {
return provisional_offline_info_.offline_page.get();
}
-bool OfflinePageTabHelper::IsShowingOfflinePreview() const {
- // TODO: Change this once offline pages infrastructure uses NavigationHandle
- // instead of a back channel. crbug.com/658899
- return provisional_offline_info_.is_showing_offline_preview ||
- offline_info_.is_showing_offline_preview;
-}
-
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698