Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: content/public/test/mock_render_thread.cc

Issue 2450353004: Move ViewHostMsg_CreateWidget to mojom (Closed)
Patch Set: Addressed @tsepez's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/mock_render_thread.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/mock_render_thread.cc
diff --git a/content/public/test/mock_render_thread.cc b/content/public/test/mock_render_thread.cc
index e5edbf98e0518c35ae3a68e8ac2def16fc14863e..ea5ed2fad362310bc68883eef55093e88690ac17 100644
--- a/content/public/test/mock_render_thread.cc
+++ b/content/public/test/mock_render_thread.cc
@@ -48,7 +48,6 @@ class MockRenderMessageFilterImpl : public mojom::RenderMessageFilter {
NOTREACHED();
}
- // Note that
bool CreateNewWindow(mojom::CreateNewWindowParamsPtr params,
mojom::CreateNewWindowReplyPtr* reply) override {
*reply = mojom::CreateNewWindowReply::New();
@@ -56,6 +55,20 @@ class MockRenderMessageFilterImpl : public mojom::RenderMessageFilter {
return true;
}
+ void CreateNewWidget(int32_t opener_id,
+ blink::WebPopupType popup_type,
+ const CreateNewWidgetCallback& callback) override {
+ // See comment in CreateNewWindow().
+ NOTREACHED();
+ }
+
+ bool CreateNewWidget(int32_t opener_id,
+ blink::WebPopupType popup_type,
+ int32_t* route_id) override {
+ thread_->OnCreateWidget(opener_id, popup_type, route_id);
+ return true;
+ }
+
private:
MockRenderThread* const thread_;
};
@@ -256,7 +269,7 @@ void MockRenderThread::SendCloseMessage() {
RenderViewImpl::FromRoutingID(routing_id_)->OnMessageReceived(msg);
}
-// The Widget expects to be returned valid route_id.
+// The Widget expects to be returned a valid route_id.
void MockRenderThread::OnCreateWidget(int opener_id,
blink::WebPopupType popup_type,
int* route_id) {
@@ -285,7 +298,6 @@ bool MockRenderThread::OnMessageReceived(const IPC::Message& msg) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(MockRenderThread, msg)
- IPC_MESSAGE_HANDLER(ViewHostMsg_CreateWidget, OnCreateWidget)
IPC_MESSAGE_HANDLER(FrameHostMsg_CreateChildFrame, OnCreateChildFrame)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
« no previous file with comments | « content/public/test/mock_render_thread.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698