Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2450353003:
android: Histogram for the GSA account change broacast mechanism. (Closed)
Descriptionandroid: Histogram for the GSA account change broadcast mechanism.
Over time, users should migrate to the broadcast-based notification
mechanism. Add a histogram to track that, and make sure that we don't
regress.
BUG=614388
Committed: https://crrev.com/cf2cb0230ac1399b0225f081858d2c410c4629e1
Cr-Commit-Position: refs/heads/master@{#429253}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Better description + typo. #
Messages
Total messages: 23 (15 generated)
lizeb@chromium.org changed reviewers: + mariakhomenko@chromium.org, yusufo@chromium.org
The CQ bit was checked by lizeb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm FYI, you'll need metrics owner approval for histograms.xml
lizeb@chromium.org changed reviewers: + isherman@chromium.org
Description was changed from ========== android: Histogram for the GSA account change broacast mechanism. Over time, users should migrate to the broadcast-based notification mechanism. Add a histogram to track that, and make sure that we don't regress. BUG=614388 ========== to ========== android: Histogram for the GSA account change broadcast mechanism. Over time, users should migrate to the broadcast-based notification mechanism. Add a histogram to track that, and make sure that we don't regress. BUG=614388 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Metrics lgtm https://codereview.chromium.org/2450353003/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2450353003/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:56114: + service or through a broadcast. This is reported once per Chrome startup. nit: once, or at most once, per startup?
The CQ bit was checked by lizeb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2450353003/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2450353003/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:56114: + service or through a broadcast. This is reported once per Chrome startup. On 2016/10/28 02:08:27, Ilya Sherman wrote: > nit: once, or at most once, per startup? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lizeb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from isherman@chromium.org, mariakhomenko@chromium.org Link to the patchset: https://codereview.chromium.org/2450353003/#ps20001 (title: "Better description + typo.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== android: Histogram for the GSA account change broadcast mechanism. Over time, users should migrate to the broadcast-based notification mechanism. Add a histogram to track that, and make sure that we don't regress. BUG=614388 ========== to ========== android: Histogram for the GSA account change broadcast mechanism. Over time, users should migrate to the broadcast-based notification mechanism. Add a histogram to track that, and make sure that we don't regress. BUG=614388 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== android: Histogram for the GSA account change broadcast mechanism. Over time, users should migrate to the broadcast-based notification mechanism. Add a histogram to track that, and make sure that we don't regress. BUG=614388 ========== to ========== android: Histogram for the GSA account change broadcast mechanism. Over time, users should migrate to the broadcast-based notification mechanism. Add a histogram to track that, and make sure that we don't regress. BUG=614388 Committed: https://crrev.com/cf2cb0230ac1399b0225f081858d2c410c4629e1 Cr-Commit-Position: refs/heads/master@{#429253} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cf2cb0230ac1399b0225f081858d2c410c4629e1 Cr-Commit-Position: refs/heads/master@{#429253} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
